Skip to content

Changed the publish of reobfuscated jars #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Icosider
Copy link

The problem is that MDG Legacy publishes the jar that was last reobfuscated. In the case where only shadowJar is used, this is useful, but when it is necessary to split the build into Client and Server, this functionality creates difficulties with publication.

This change allows you to specify the task that needs to be published. I also made sure that the Jar task was handled correctly.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 29, 2025

  • Publish PR to GitHub Packages

Last commit published: f6401e464ef3b7489e69e489b011905edfd7ade2.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #232' // https://github.com/neoforged/ModDevGradle/pull/232
        url 'https://prmaven.neoforged.net/ModDevGradle/pr232'
        content {
            includeModule('net.neoforged.moddev.legacyforge', 'net.neoforged.moddev.legacyforge.gradle.plugin')
            includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin')
            includeModule('net.neoforged.moddev.repositories', 'net.neoforged.moddev.repositories.gradle.plugin')
            includeModule('net.neoforged', 'moddev-gradle')
        }
    }
}

@Icosider
Copy link
Author

Icosider commented Feb 6, 2025

@shartte, can u toggle the checkbox?

@Technici4n
Copy link
Member

This introduces a breaking change in the API which is quite problematic. Let's instead try to be less careless with clear() so that two subsequent reobfuscate calls work as expected.

@Technici4n Technici4n closed this May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants