Changed the publish of reobfuscated jars#232
Closed
Icosider wants to merge 2 commits intoneoforged:mainfrom
Icosider:publishing-legacy
Closed
Changed the publish of reobfuscated jars#232Icosider wants to merge 2 commits intoneoforged:mainfrom Icosider:publishing-legacy
Icosider wants to merge 2 commits intoneoforged:mainfrom
Icosider:publishing-legacy
Conversation
Last commit published: f6401e464ef3b7489e69e489b011905edfd7ade2. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #232' // https://github.com/neoforged/ModDevGradle/pull/232
url 'https://prmaven.neoforged.net/ModDevGradle/pr232'
content {
includeModule('net.neoforged.moddev.legacyforge', 'net.neoforged.moddev.legacyforge.gradle.plugin')
includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin')
includeModule('net.neoforged.moddev.repositories', 'net.neoforged.moddev.repositories.gradle.plugin')
includeModule('net.neoforged', 'moddev-gradle')
}
}
} |
Author
|
@shartte, can u toggle the checkbox? |
Member
|
This introduces a breaking change in the API which is quite problematic. Let's instead try to be less careless with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is that MDG Legacy publishes the jar that was last reobfuscated. In the case where only shadowJar is used, this is useful, but when it is necessary to split the build into Client and Server, this functionality creates difficulties with publication.
This change allows you to specify the task that needs to be published. I also made sure that the Jar task was handled correctly.