Revert synthetic checks

Fixes #2
neoforged · Jun 23, 2024 · ef8d008 · ef8d008
1 parent d40d440
commit ef8d008
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 10 deletions.
diff --git a/src/main/java/net/neoforged/jarcompatibilitychecker/core/ClassInfoComparer.java b/src/main/java/net/neoforged/jarcompatibilitychecker/core/ClassInfoComparer.java
@@ -15,7 +15,6 @@
 import net.neoforged.jarcompatibilitychecker.data.MemberInfo;
 import net.neoforged.jarcompatibilitychecker.data.MethodInfo;
 import net.neoforged.jarcompatibilitychecker.sort.TopologicalSort;
-import net.neoforged.jarcompatibilitychecker.util.AccessHelpers;
 import org.jetbrains.annotations.Nullable;
 import org.objectweb.asm.Opcodes;
 
@@ -116,9 +115,6 @@ public static ClassInfoComparisonResults compare(boolean checkBinary, @Nullable
         Set<MethodInfo> seenMethods = new HashSet<>();
 
         for (MethodInfo baseInfo : baseClassInfo.getMethods().values()) {
-            // base synthetic -> ignore changes
-            if (AccessHelpers.isSynthetic(baseInfo) && !AccessHelpers.isBridge(baseInfo)) continue;
-
             boolean isStatic = (baseInfo.access & Opcodes.ACC_STATIC) != 0;
             MethodInfo inputInfo = getMethodInfo(concreteClassInfo, concreteParents, isStatic, baseInfo.name, baseInfo.desc);
             boolean methodInternal = classInternal || isInternalApi(baseInfo, internalAnnotations, internalAnnotationCheckMode, packageInfo);
@@ -128,8 +124,7 @@ public static ClassInfoComparisonResults compare(boolean checkBinary, @Nullable
             boolean isMethodError = !methodInternal || internalAnnotationCheckMode == InternalAnnotationCheckMode.ERROR;
             boolean methodVisible = isVisible(checkBinary, baseInfo.access);
 
-            // base non-synthetic -> synthetic should be considered an error as synthetic methods aren't stable
-            if (inputInfo == null || (AccessHelpers.isSynthetic(inputInfo) && !AccessHelpers.isBridge(inputInfo))) {
+            if (inputInfo == null) {
                 if (checkBinary) {
                     results.addMethodIncompatibility(baseInfo, IncompatibilityMessages.METHOD_REMOVED, isMethodError);
                 } else if (methodVisible) {

diff --git a/tests/base/src/main/java/com/example/test/TestClassA.java b/tests/base/src/main/java/com/example/test/TestClassA.java
@@ -7,9 +7,6 @@
 
 public class TestClassA {
     public String field;
-    public Runnable lambdaThing = () -> {
-        System.out.println("Hi!");
-    };
     public void publicMethodA(String p1) {
 
     }

diff --git a/tests/top/src/main/java/com/example/test/TestClassA.java b/tests/top/src/main/java/com/example/test/TestClassA.java
@@ -2,7 +2,6 @@
 
 abstract class TestClassA {
     public final String field = "a";
-    public Runnable lambdaThing;
     private void publicMethodA(String p1) {
 
     }