Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add infrastructure to sync server config changes to connected clients #192

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add infrastructure to sync server config changes to connected clients #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions loader/src/main/java/net/neoforged/fml/Bindings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,11 @@

import java.util.ServiceLoader;
import net.neoforged.bus.api.IEventBus;
import net.neoforged.fml.config.IConfigSpec;
import net.neoforged.fml.config.ModConfig;
import net.neoforged.fml.loading.FMLLoader;
import org.jetbrains.annotations.ApiStatus;
import org.jetbrains.annotations.Nullable;

@ApiStatus.Internal
public class Bindings {
Expand All @@ -26,4 +29,8 @@ public class Bindings {
public static IEventBus getGameBus() {
return provider.getGameBus();
}

public static void fireConfigChanged(ModConfig modConfig, @Nullable IConfigSpec.ILoadedConfig loadedConfig) {
provider.onConfigChanged(modConfig, loadedConfig);
}
}
9 changes: 9 additions & 0 deletions loader/src/main/java/net/neoforged/fml/IBindingsProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,18 @@
package net.neoforged.fml;

import net.neoforged.bus.api.IEventBus;
import net.neoforged.fml.config.IConfigSpec;
import net.neoforged.fml.config.ModConfig;
import org.jetbrains.annotations.ApiStatus;
import org.jetbrains.annotations.Nullable;

@ApiStatus.Internal
public interface IBindingsProvider {
IEventBus getGameBus();

/**
* Invoked when a config changed or might have changed, but not necessarily when a config is loaded.
* This method may be called from any thread, at any time.
*/
void onConfigChanged(ModConfig modConfig, @Nullable IConfigSpec.ILoadedConfig loadedConfig);
}
2 changes: 2 additions & 0 deletions loader/src/main/java/net/neoforged/fml/config/LoadedConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

import com.electronwill.nightconfig.core.CommentedConfig;
import java.nio.file.Path;
import net.neoforged.fml.Bindings;
import net.neoforged.fml.event.config.ModConfigEvent;
import org.jetbrains.annotations.Nullable;

Expand All @@ -22,5 +23,6 @@ public void save() {
} finally {
modConfig.lock.unlock();
}
Bindings.fireConfigChanged(modConfig, this);
}
}
3 changes: 3 additions & 0 deletions loader/src/main/java/net/neoforged/fml/config/ModConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import java.util.concurrent.locks.Lock;
import java.util.concurrent.locks.ReentrantLock;
import java.util.function.Function;
import net.neoforged.fml.Bindings;
import net.neoforged.fml.ModContainer;
import net.neoforged.fml.event.config.ModConfigEvent;
import net.neoforged.fml.loading.StringUtils;
Expand Down Expand Up @@ -80,6 +81,8 @@ void setConfig(@Nullable LoadedConfig loadedConfig, Function<ModConfig, ModConfi
} finally {
lock.unlock();
}

Bindings.fireConfigChanged(this, loadedConfig);
}

public enum Type {
Expand Down
Loading