Catalog Endpoints Part 1 #926
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-graph-data-science-client canceled.
|
DarthMax
force-pushed
the
catalog_endpoints
branch
from
41eba1a to
4f96f34
Compare
FlorentinD
approved these changes
Jul 31, 2025
Comment on lines
69
to
70
| class GraphListResult(BaseModel): | ||
| model_config = ConfigDict(alias_generator=to_camel) |
There was a problem hiding this comment.
Suggested change
| class GraphListResult(BaseModel): | |
| model_config = ConfigDict(alias_generator=to_camel) | |
| class GraphListResult(BaseModel, alias_generator=to_camel): |
its allowed to be passed like this.
Easier to not confuse with the actual fields.
(see for reference -- https://github.com/neo4j/python-graph-visualization/blob/553f47130b514d7d93f5c3206d1eb9a32958b846/python-wrapper/src/neo4j_viz/node.py#L29)
There was a problem hiding this comment.
Uh that is nice. I was generally thinking if we might want to introduce our own base class for all those results, that one could already define all the necessary options. WDYT?
Comment on lines
94
to
95
| class GraphFilterResult(BaseModel): | ||
| model_config = ConfigDict(alias_generator=to_camel) |
There was a problem hiding this comment.
Suggested change
| class GraphFilterResult(BaseModel): | |
| model_config = ConfigDict(alias_generator=to_camel) | |
| class GraphFilterResult(BaseModel, alias_generator=to_camel)): |
graphdatascience/procedure_surface/arrow/catalog_arrow_endpoints.py
Outdated
Show resolved
Hide resolved
graphdatascience/procedure_surface/arrow/catalog_arrow_endpoints.py
Outdated
Show resolved
Hide resolved
Comment on lines
+67
to
+68
|
|
||
|
|
There was a problem hiding this comment.
No, project is very implementation dependent, for Cypher+Plugin it will be native projection, Arrow+Session -> remote projection, Arrow + Plugin?? that is why I skipped that.
graphdatascience/tests/integrationV2/procedure_surface/arrow/conftest.py
Outdated
Show resolved
Hide resolved
graphdatascience/tests/integrationV2/procedure_surface/arrow/conftest.py
Outdated
Show resolved
Hide resolved
graphdatascience/tests/integrationV2/procedure_surface/arrow/conftest.py
Outdated
Show resolved
Hide resolved
graphdatascience/tests/integrationV2/procedure_surface/arrow/conftest.py
Outdated
Show resolved
Hide resolved
graphdatascience/tests/integrationV2/procedure_surface/arrow/test_catalog_arrow_endpoints.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Florentin Dörre <[email protected]>
Co-authored-by: Florentin Dörre <[email protected]>
Co-authored-by: Florentin Dörre <[email protected]>
DarthMax
force-pushed
the
catalog_endpoints
branch
from
66f3c1b to
0646005
Compare
Co-authored-by: Florentin Dörre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref GDSA-75