-
Notifications
You must be signed in to change notification settings - Fork 118
[DBFT] Optimize dBFT Consensus Timing Mechanism #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This has nothing to do with hardforks. At all.
- This doesn't make any sense as a NEP to me. dBFT stays the same, timer management is deeply internal to it and 3.7 will be compatible with 3.8 wrt this even if they slightly deviate.
- The description is insufficient for any kind of implementation. What is
T(n)
really? It will be different on different machines. What isTc
, when consensus is considered to be started and when is it considered to be finished wrt dBFT cycle?
It needs hardfork to ensure all consensus node works the same.
Its OK if you dont think it should be this way, its not required to merge a draft.
I can update for better description. |
I am trying to make everything standardized, may make many mistakes, not intentional mistakes, but appologize for those in advance. I have no idea what should be an NEP, what should not be an NEP, its up to the team to decide and i accept the team decision, |
Nope. This adjustment is backwards-compatible, for most networks the difference won't affect correctness.
@Jim8y, don't get me wrong, this is what I totally support and I will help with any protocol formalization efforts. It's just that this particular case is arguable for two reasons: we don't have dBFT NEP and this doesn't change the algorithm itself in any way. It's an implementation detail which has some importance, but maybe not requiring NEP. At the same time, I agree that
And if the majority find this NEP useful then it should be explained in dBFT terms, so that it could be understood and implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already merged in HF_Echidna
should we move on?
As we plan to reduce the block time in future updates, network latency issues will have a more pronounced impact on block generation speed. This could potentially slow down the block production rate and, consequently, affect the
GAS
generation rate. Therefore, we need to implement a mechanism to minimize these latency effects and maintain a stable gas generation rate across the network.