Exec Factor with decimals #4202

shargon · 2025-10-01T08:37:57Z

Description

Please @neo-project/core review this PR, as we agree in Centre Point it's important for the community.
Was decided in Centre Point to have two decimals in ExecutionFactor this PR tries to address it

Type of change

Optimization (the change is only an optimization)
Style (the change is only a code style for better maintenance or standard purpose)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Test A
Test B

Test Configuration:

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

src/Neo/SmartContract/ApplicationEngine.Contract.cs

src/Neo/SmartContract/ApplicationEngine.cs

This reverts commit 474c2f5.

src/Neo/SmartContract/Native/PolicyContract.cs

src/Neo/SmartContract/ApplicationEngine.cs

roman-khimov

Much cleaner now. But I'd also adjust BurnGas() since it's documented to use datoshis and for its users (if there are any) that should be sufficient.

src/Neo/SmartContract/ApplicationEngine.cs

shargon · 2025-10-03T08:53:50Z

I think it could be more clear if we multiply inside AddFee method, otherwise, AddFee it's in picoDatoshi and BurnFee it's in datoshi, what do you think @roman-khimov @AnnaShaleva?

roman-khimov · 2025-10-03T08:58:26Z

AddFee is an internal thing, BurnFee is only used by contracts. To me it's not a problem.

shargon · 2025-10-06T10:38:14Z

Please @neo-project/core review this PR, as we agree in Centre Point it's important for the community.

Important changes areas:

AddFee should use picoDatoshi always

src/Neo/SmartContract/Native/PolicyContract.cs

roman-khimov · 2025-10-06T16:05:10Z

AddFee should use picoDatoshi always

picoGAS! It's 8+4, so 1^-12. picoDatoshi would be 1^-20.

src/Neo/SmartContract/ApplicationEngine.cs

shargon · 2025-10-28T10:41:38Z

Please @neo-project/core review this PR

vncoelho · 2025-10-28T11:56:58Z

Without the current state of dev I can not completely test.
But from my previous test it is fine to me.

superboyiii · 2025-10-29T08:18:16Z

Don't we need a Hardfork for this? It changes fee calculation logic.

ContractManagement storage will be incompatible at the beginning...

shargon · 2025-10-29T09:50:49Z

Don't we need a Hardfork for this? It changes fee calculation logic. ContractManagement storage will be incompatible at the beginning...

We have the fork logic, at what height did you set the HF_Faun fork?

superboyiii · 2025-10-29T09:57:51Z

We have the fork logic, at what height did you set the HF_Faun fork?

Block 0.
I surely set fork height at a higher one.

    "Hardforks": {
      "HF_Aspidochelone": 1730000,
      "HF_Basilisk": 4120000,
      "HF_Cockatrice": 5450000,
      "HF_Domovoi": 5570000,
      "HF_Echidna": 7300000,
      "HF_Faun": 8300000,
      "HF_Gorgon": 8300000
    },

superboyiii · 2025-10-29T10:40:30Z

In genesis block
v3.8.2:

        {
            "id": -1,
            "state": "Added",
            "key": "/////wh7xoHAofcdVDRXtou6jV\u002Bf3U5ezA==",
            "value": "QAUhAfkhACgUe8aBwKH3HVQ0V7aLuo1fn91OXswom05FRjNuZW8tY29yZS12My4wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABNEEEa93tnQBBBGvd7Z0AQQRr3e2dAEEEa93tnQBBBGvd7Z0AQQRr3e2dAEEEa93tnQBBBGvd7Z0AQQRr3e2dAEEEa93tnQBBBGvd7Z0BIETlBQQgoDlBvbGljeUNvbnRyYWN0QABIAEAAQQJAC0EFKAxibG9ja0FjY291bnRAAUECKAdhY2NvdW50IQEUIQEQIQAgAEEFKA9nZXRBdHRyaWJ1dGVGZWVAAUECKA1hdHRyaWJ1dGVUeXBlIQERIQERIQEHIAFBBSgQZ2V0RXhlY0ZlZUZhY3RvckAAIQERIQEOIAFBBSgNZ2V0RmVlUGVyQnl0ZUAAIQERIQEVIAFBBSgPZ2V0U3RvcmFnZVByaWNlQAAhAREhARwgAUEFKAlpc0Jsb2NrZWRAAUECKAdhY2NvdW50IQEUIQEQIQEjIAFBBSgPc2V0QXR0cmlidXRlRmVlQAJBAigNYXR0cmlidXRlVHlwZSEBEUECKAV2YWx1ZSEBESEC/wAhASogAEEFKBBzZXRFeGVjRmVlRmFjdG9yQAFBAigFdmFsdWUhAREhAv8AIQExIABBBSgNc2V0RmVlUGVyQnl0ZUABQQIoBXZhbHVlIQERIQL/ACEBOCAAQQUoD3NldFN0b3JhZ2VQcmljZUABQQIoBXZhbHVlIQERIQL/ACEBPyAAQQUoDnVuYmxvY2tBY2NvdW50QAFBAigHYWNjb3VudCEBFCEBECEBRiAAQABAAUECAABAACgEbnVsbA=="
        }

This one:

        {
            "id": -1,
            "state": "Added",
            "key": "/////wh7xoHAofcdVDRXtou6jV\u002Bf3U5ezA==",
            "value": "QAUhAfkhACgUe8aBwKH3HVQ0V7aLuo1fn91OXswook5FRjNuZW8tY29yZS12My4wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABUEEEa93tnQBBBGvd7Z0AQQRr3e2dAEEEa93tnQBBBGvd7Z0AQQRr3e2dAEEEa93tnQBBBGvd7Z0AQQRr3e2dAEEEa93tnQBBBGvd7Z0AQQRr3e2dAf6N\u002B1UEIKA5Qb2xpY3lDb250cmFjdEAASABAAEECQAxBBSgMYmxvY2tBY2NvdW50QAFBAigHYWNjb3VudCEBFCEBECEAIABBBSgPZ2V0QXR0cmlidXRlRmVlQAFBAigNYXR0cmlidXRlVHlwZSEBESEBESEBByABQQUoEGdldEV4ZWNGZWVGYWN0b3JAACEBESEBDiABQQUoFGdldEV4ZWNQaWNvRmVlRmFjdG9yQAAhAREhARUgAUEFKA1nZXRGZWVQZXJCeXRlQAAhAREhARwgAUEFKA9nZXRTdG9yYWdlUHJpY2VAACEBESEBIyABQQUoCWlzQmxvY2tlZEABQQIoB2FjY291bnQhARQhARAhASogAUEFKA9zZXRBdHRyaWJ1dGVGZWVAAkECKA1hdHRyaWJ1dGVUeXBlIQERQQIoBXZhbHVlIQERIQL/ACEBMSAAQQUoEHNldEV4ZWNGZWVGYWN0b3JAAUECKAV2YWx1ZSEBESEC/wAhATggAEEFKA1zZXRGZWVQZXJCeXRlQAFBAigFdmFsdWUhAREhAv8AIQE/IABBBSgPc2V0U3RvcmFnZVByaWNlQAFBAigFdmFsdWUhAREhAv8AIQFGIABBBSgOdW5ibG9ja0FjY291bnRAAUECKAdhY2NvdW50IQEUIQEQIQFNIABAAEABQQIAAEAAKARudWxs"
        }

/////wh7xoHAofcdVDRXtou6jV\u002Bf3U5ezA== base64 to Hex: ffffffff087bc681c0a1f71d543457b68bba8d5f9fdd4e5ecc
7b68bba8d5f9fdd4e5ecc is apparently Policy contract. So policy contract registered in genesis contractmanagement contract has data incompatible.

Wi1l-B0t · 2025-10-29T11:25:02Z

The gasconsumed in Application Log before HF_Faun is Datoshi.

The gasconsumed in Application Log after HF_Faun is Datoshi or PicoGAS?

…t/neo into exec-fee-two-decimals

shargon · 2025-10-29T11:59:40Z

Thanks @superboyiii ! please check it again, it should be fixed

shargon · 2025-10-29T12:00:25Z

he gasconsumed in Application Log is Datoshi or PicoGAS?

should not be changed outside the ApplicationEngine

AnnaShaleva

Let me check it with NeoGo implementation.

src/Neo/SmartContract/ApplicationEngine.cs

Co-authored-by: Anna Shaleva <[email protected]>

src/Neo/SmartContract/ApplicationEngine.cs

superboyiii · 2025-10-30T07:32:45Z

I tried some blocks, no incompatible data found. Let me make a full sync to check all.

AnnaShaleva · 2025-10-31T11:18:19Z

src/Neo/SmartContract/ApplicationEngine.cs

-                ExecFeeFactor = NativeContract.Policy.GetExecFeeFactor(snapshotCache);
+                if (settings == null || !settings.IsHardforkEnabled(Hardfork.HF_Faun, persistingBlock?.Index ?? NativeContract.Ledger.CurrentIndex(snapshotCache)))
+                {
+                    // The values doesn't have the decimals stored
+                    _execFeeFactor = NativeContract.Policy.GetExecFeeFactor(this) * FeeFactor;
+                }
+                else
+                {
+                    // The values have the decimals stored
+                    _execFeeFactor = NativeContract.Policy.GetExecPicoFeeFactor(this);
+                }
+


@shargon it seems that this logic doesn't work correctly in the following situation (I discovered it while porting this logic to NeoGo and it looks like it works the same way in C#, but I need you to recheck that):

Consider this ApplicationEngine constructor is called before processing OnPersist trigger of Faun's block.

settings.IsHardforkEnabled(Hardfork.HF_Faun, ...) at line 232 returns true, because Faun is already enabled at persisting block.

However, Policy's OnPersist wasn't yet executed, hence there's old 1 ExecFeeFactor value stored in the Policy's storage.

So we end up in a situation when the else branch is executed at line 240, as a result _execFeeFactor will be set to 1 instead of 10000.

So I think we need a special condition for OnPersist trigger of Faun block here. Please, check it.

We can use a different key, if is not stored, make another query

I think we don't need a different key, the old one works fine after migration, we just need to properly handle the situation when migration isn't done yet.

E.g. something like that: https://github.com/nspcc-dev/neo-go/blob/795a954b21906ad641424f6a0200805447328fb3/pkg/core/blockchain.go#L3468

@AnnaShaleva Could you propose the required changes?

Ping @AnnaShaleva

superboyiii · 2025-11-03T07:37:09Z

Storage is compatible now.

Start two decimal execution factor

474c2f5

roman-khimov reviewed Oct 1, 2025

View reviewed changes

src/Neo/SmartContract/ApplicationEngine.Contract.cs Outdated Show resolved Hide resolved

roman-khimov mentioned this pull request Oct 1, 2025

[N4] Whitelist of Free Contracts #4201

Open

15 tasks

shargon commented Oct 1, 2025

View reviewed changes

src/Neo/SmartContract/ApplicationEngine.cs Outdated Show resolved Hide resolved

cschuchardt88 added the Work in Progress label Oct 2, 2025

shargon added 4 commits October 2, 2025 09:19

Revert "Start two decimal execution factor"

08e3a35

This reverts commit 474c2f5.

Draft with two dec

3c58e8c

Check HF in max values

d9c4b4c

Add comments

006bac1

shargon marked this pull request as ready for review October 2, 2025 07:50

AnnaShaleva reviewed Oct 2, 2025

View reviewed changes

src/Neo/SmartContract/Native/PolicyContract.cs Outdated Show resolved Hide resolved

src/Neo/SmartContract/ApplicationEngine.cs Outdated Show resolved Hide resolved

src/Neo/SmartContract/ApplicationEngine.cs Outdated Show resolved Hide resolved

roman-khimov reviewed Oct 2, 2025

View reviewed changes

src/Neo/SmartContract/ApplicationEngine.cs Outdated Show resolved Hide resolved

src/Neo/SmartContract/ApplicationEngine.cs Outdated Show resolved Hide resolved

shargon changed the title ~~Exec Factor with two decimals~~ Exec Factor with decimals Oct 3, 2025

shargon added 4 commits October 3, 2025 10:30

4 decimals

ad5365e

Add extra checks

5b04634

Anna's feedback

0cafd92

Use CeilingDivide

c19b679

shargon mentioned this pull request Oct 3, 2025

Ceiling Divide BigInteger extension #4208

Merged

15 tasks

Merge branch 'dev' into exec-fee-two-decimals

6bb4a7e

shargon added the Critical Issues (bugs) that need to be fixed ASAP label Oct 6, 2025

shargon commented Oct 6, 2025

View reviewed changes

src/Neo/SmartContract/Native/PolicyContract.cs Show resolved Hide resolved

shargon added Help Wanted We suggest a careful read at https://docs.neo.org/. However, fell free to further discuss the topic. and removed Work in Progress labels Oct 6, 2025

vncoelho reviewed Oct 6, 2025

View reviewed changes

src/Neo/SmartContract/ApplicationEngine.cs Outdated Show resolved Hide resolved

shargon mentioned this pull request Oct 8, 2025

Dev Meeting Thursday 10.9.2025 #4217

Closed

Merge branch 'dev' into exec-fee-two-decimals

142e3e9

Wi1l-B0t previously approved these changes Oct 28, 2025

View reviewed changes

shargon requested a review from superboyiii October 28, 2025 15:44

shargon added the Need Testing label Oct 28, 2025

ajara87 previously approved these changes Oct 28, 2025

View reviewed changes

shargon added 2 commits October 29, 2025 12:58

Set GetExecPicoFeeFactor to Faun only

20faa2f

Merge branch 'exec-fee-two-decimals' of https://github.com/neo-projec…

9fa5998

…t/neo into exec-fee-two-decimals

shargon dismissed stale reviews from ajara87 and Wi1l-B0t via 9fa5998 October 29, 2025 11:58

AnnaShaleva reviewed Oct 29, 2025

View reviewed changes

src/Neo/SmartContract/ApplicationEngine.cs Show resolved Hide resolved

src/Neo/SmartContract/ApplicationEngine.cs Outdated Show resolved Hide resolved

shargon and others added 2 commits October 29, 2025 15:25

Update src/Neo/SmartContract/ApplicationEngine.cs

86da21d

Co-authored-by: Anna Shaleva <[email protected]>

Merge branch 'dev' into exec-fee-two-decimals

24efa67

ajara87 previously approved these changes Oct 29, 2025

View reviewed changes

shargon commented Oct 29, 2025

View reviewed changes

src/Neo/SmartContract/ApplicationEngine.cs Outdated Show resolved Hide resolved

Update src/Neo/SmartContract/ApplicationEngine.cs

b3932fa

shargon dismissed ajara87’s stale review via b3932fa October 29, 2025 22:47

ajara87 approved these changes Oct 29, 2025

View reviewed changes

AnnaShaleva reviewed Oct 31, 2025

View reviewed changes

Merge branch 'dev' into exec-fee-two-decimals

391edb6

Wi1l-B0t approved these changes Nov 4, 2025

View reviewed changes

Exec Factor with decimals #4202

Are you sure you want to change the base?

Exec Factor with decimals #4202

Conversation

shargon commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

roman-khimov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shargon commented Oct 3, 2025

Uh oh!

roman-khimov commented Oct 3, 2025

Uh oh!

shargon commented Oct 6, 2025

Uh oh!

Uh oh!

roman-khimov commented Oct 6, 2025

Uh oh!

Uh oh!

shargon commented Oct 28, 2025

Uh oh!

vncoelho commented Oct 28, 2025

Uh oh!

superboyiii commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shargon commented Oct 29, 2025

Uh oh!

superboyiii commented Oct 29, 2025

Uh oh!

superboyiii commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Wi1l-B0t commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shargon commented Oct 29, 2025

Uh oh!

shargon commented Oct 29, 2025

Uh oh!

AnnaShaleva left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

superboyiii commented Oct 30, 2025

Uh oh!

AnnaShaleva Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shargon Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

AnnaShaleva Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

AnnaShaleva Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

shargon Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

shargon Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

superboyiii commented Nov 3, 2025

shargon commented Oct 1, 2025 •

edited

Loading

superboyiii commented Oct 29, 2025 •

edited

Loading

superboyiii commented Oct 29, 2025 •

edited

Loading

Wi1l-B0t commented Oct 29, 2025 •

edited

Loading

AnnaShaleva Oct 31, 2025 •

edited

Loading