Fix forward-referenced contract dependencies #1415
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all smart contract symbols before building the dependency graph
contracts declared later are preserved and _nonDependencies cannot trim
required types
rest of the compilation flow unchanged
Issue:
CompilationEngine only added a smart contract to classDependencies after it
had already been visited, so a field or property that pointed to a contract
declared later looked like a plain class reference. When _nonDependencies
ran, those untracked contracts were considered foreign and stripped from the
compilation context, leading to partial NEF output in multi-contract projects.
Fix Details:
The change executes two passes over the syntax trees:
contract symbol to the dependency list, deduplicating and skipping abstract
types.
This ensures the subsequent topological sort sees the full dependency graph
regardless of declaration order, so every required contract is compiled and
emitted.