[s3inbox] store uploaded file size in db #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbygdell
force-pushed
the
feature/s3inbox-stores-size-in-db
branch
2 times, most recently
from
11b0659 to
ff3cf70
Compare
jbygdell
force-pushed
the
feature/s3inbox-stores-size-in-db
branch
from
ff3cf70 to
d3924ec
Compare
jbygdell
force-pushed
the
feature/s3inbox-stores-size-in-db
branch
3 times, most recently
from
ab56a5f to
eeef60e
Compare
Upload a file and directly check the object size.
jbygdell
force-pushed
the
feature/s3inbox-stores-size-in-db
branch
from
eeef60e to
e88d3b0
Compare
jbygdell
force-pushed
the
feature/s3inbox-stores-size-in-db
branch
from
84e37c3 to
372caf1
Compare
jbygdell
force-pushed
the
feature/s3inbox-stores-size-in-db
branch
from
372caf1 to
153fa67
Compare
nanjiangshu
reviewed
Apr 14, 2025
nanjiangshu
reviewed
Apr 14, 2025
nanjiangshu
reviewed
Apr 14, 2025
pahatz
approved these changes
Apr 15, 2025
pahatz
reviewed
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes #1482 .
This will be kept as a draft until #1543 is mergedDescription
This PA adds a function that stores the size of the uploaded file in the database (
submission_file_size) upon completed upload. The size of the file is read from the S3 backend.3 test cases could be generated, 1 positive and 2 negative. The 4th test case (fastCheck) didn't go as planned but will be kept in order to catch any regression.
How to test