-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cron job to run large submission tests #1520
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this looks very good to me!
Some details are not clear to me, however. Shouldn't we check what error messages we get in the error queue? To make sure that they are due to files that can't be found, and not something else?
Well, the only test that is of relevance is the test for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I can't seem to remember why it's ok to have the finalize test failing.
70f789e
to
943524e
Compare
The test for finalize is expected to fail for now.
Co-authored-by: Alex Aperis <[email protected]>
aa885a0
to
dbb3bfb
Compare
d23e5fc
to
e1552b2
Compare
The test for finalize is expected to fail for now.
Related issue(s) and PR(s)
This PR closes #1504 .
Description
These tests create DB entries for 100k files, sends the messages to the MQ.
The test suite is run as a cronjob on Saturdays, all 4 tests are run in parallel in order to cope with the max runtime of 6h for a job.
Expected results
How to test
Once merged there is an option to manually trigger the tests.