Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cron job to run large submission tests #1520

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

jbygdell
Copy link
Collaborator

@jbygdell jbygdell commented Mar 26, 2025

The test for finalize is expected to fail for now.

Related issue(s) and PR(s)

This PR closes #1504 .

Description

These tests create DB entries for 100k files, sends the messages to the MQ.

The test suite is run as a cronjob on Saturdays, all 4 tests are run in parallel in order to cope with the max runtime of 6h for a job.

Expected results

  • finalize - failed test due to timeout
  • ingest - passed test, 100k messages sent to the error queue
  • mapper- passed test, no errors
  • verify - passed test, 100k messages sent to the error queue

How to test

Once merged there is an option to manually trigger the tests.

@jbygdell jbygdell added github_actions Pull requests that update GitHub Actions code Test labels Mar 26, 2025
@jbygdell jbygdell requested a review from a team March 26, 2025 07:48
@jbygdell jbygdell self-assigned this Mar 26, 2025
Copy link
Contributor

@MalinAhlberg MalinAhlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this looks very good to me!

Some details are not clear to me, however. Shouldn't we check what error messages we get in the error queue? To make sure that they are due to files that can't be found, and not something else?

@jbygdell
Copy link
Collaborator Author

In general, this looks very good to me!

Some details are not clear to me, however. Shouldn't we check what error messages we get in the error queue? To make sure that they are due to files that can't be found, and not something else?

Well, the only test that is of relevance is the test for mapper, the other ones will behave the same regardless of the number of messages/files.

pahatz
pahatz previously approved these changes Mar 31, 2025
Copy link
Contributor

@pahatz pahatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@aaperis aaperis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I can't seem to remember why it's ok to have the finalize test failing.

@jbygdell jbygdell force-pushed the large-tests branch 5 times, most recently from 70f789e to 943524e Compare April 8, 2025 08:06
@jbygdell jbygdell force-pushed the large-tests branch 3 times, most recently from aa885a0 to dbb3bfb Compare April 10, 2025 10:26
@jbygdell jbygdell force-pushed the large-tests branch 2 times, most recently from d23e5fc to e1552b2 Compare April 11, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tests] Add tests for large datasets in terms of files (separate from the other tests of the workflow)
4 participants