use atomics for started and activity flags
#2019
Merged
+19
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
commented
Aug 8, 2025
|
@kumaraditya303 what do you think of #2020? |
I think using c11 atomics is definitely better than writing manual atomic platform dependent code if using newer msvc is not an issue, if you prefer it as well then I will update this PR based on that. |
|
#2020 does look better to me. As I've said elsewhere, I no basically nothing about the versions of compilers and so on. It seems to work in CI, so let's go with it. |
kumaraditya303
force-pushed
the
thread-safe-resume2
branch
from
d5b1429 to
6ea0900
Compare
|
Okay, I have updated the PR to use c11 atomics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.