Skip to content

Conversation

shenanigansd
Copy link

@shenanigansd shenanigansd commented Oct 22, 2024

Add a filter to testsuite.yml to only run when .py files are changed.

This should cleanly coexist with the existing branch filter:

If you define both branches/branches-ignore and paths/paths-ignore, the workflow will only run when both filters are satisfied.
- https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore

ref: https://discord.com/channels/267624335836053506/1253355750684753950/1298279250830557236

@shenanigansd
Copy link
Author

Hmm, tests are a required check. Since we skipped them, that check will never pass. This is awkward.

@nedbat
Copy link
Owner

nedbat commented Oct 22, 2024

The tests are skipped if the branch is named *notests*, can we use the same mechanism?

@shenanigansd shenanigansd marked this pull request as draft October 22, 2024 17:23
@nedbat
Copy link
Owner

nedbat commented Jul 6, 2025

Thanks for this, sorry I didn't merge it. In the meantime, I've added more elaborate filtering to the workflows: https://github.com/nedbat/coveragepy/blob/master/.github/workflows/testsuite.yml#L31-L56

@nedbat nedbat closed this Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants