Bort fra data class i API - take2 #1351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l class, for å ha meir kontroll
…også litt malplassert, så da kan vi like godt duplisere
…andre data class i dsl-modulen
routsi
reviewed
Mar 10, 2025
brevbaker-dsl/src/main/kotlin/no/nav/pensjon/brev/template/IncludeAttachment.kt
Outdated
Show resolved
Hide resolved
routsi
reviewed
Mar 10, 2025
brevbaker-dsl/src/main/kotlin/no/nav/pensjon/brev/template/LanguageCombination.kt
Outdated
Show resolved
Hide resolved
routsi
reviewed
Mar 10, 2025
brevbaker-dsl/src/main/kotlin/no/nav/pensjon/brev/template/LanguageSettings.kt
Outdated
Show resolved
Hide resolved
routsi
reviewed
Mar 10, 2025
| @@ -78,8 +93,15 @@ sealed class UnaryOperation<In, out Out> : Operation() { | |||
| } | |||
|
|
|||
| abstract class BinaryOperation<in In1, in In2, out Out>(val doc: Documentation? = null) : Operation() { | |||
| data class Documentation(val name: String, val syntax: Notation) { | |||
| class Documentation @InternKonstruktoer constructor(val name: String, val syntax: Notation) { | |||
There was a problem hiding this comment.
Jeg lurer på om akkuratt denne klassen burde ha public konstruktør. Om vi skal oppfordre til tilpasning av brevbaker gjennom operasjoner.
routsi
reviewed
Mar 10, 2025
| import no.nav.pensjon.brev.template.dsl.textExpr | ||
| import no.nav.pensjon.brevbaker.api.model.Kroner | ||
|
|
||
| data class KronerText(val kroner: Expression<Kroner>, val fontType: Element.OutlineContent.ParagraphContent.Text.FontType = Element.OutlineContent.ParagraphContent.Text.FontType.PLAIN) : |
There was a problem hiding this comment.
Er denne flyttet fordi det kun er etterlatte som bruker den?
There was a problem hiding this comment.
Nei, brukast også i pensjonsmaler. Men det kjentes litt rart og inkonsekvent at dette var den einaste frasa vi hadde i biblioteket, så da trur eg det er betre å duplisere.
…eita i prodkoden utan å kåle til for testane våre
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.