Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legg til diff på config #2503

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sirimykland
Copy link

No description provided.

@sirimykland sirimykland force-pushed the experimental/test-ny-editorconfig branch from 6325dbc to 3413c09 Compare June 21, 2024 09:45
@sirimykland sirimykland force-pushed the experimental/test-ny-editorconfig branch from 3413c09 to 7d8af71 Compare June 21, 2024 10:09
Comment on lines +7 to +15
[*.java]
[*.json]
[*.md]
[*.{yml,yaml}]
[*]
[pom.xml]
charset = utf-8
charset = utf-8
end_of_line = lf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ulempen med denne approachen er at man mister kontekst over hvilken fil typer dette gjelder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vi kunne kanskje starte med [*.java] evt [pom.xml] først?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det er ikke meningen at filen skal være sortert alfabetisk når vi bruker den. (Tror ikke konfigen vil funke slik den er nå uansett). Jeg har bare sortert den her fordi Jens Otto ville se diffen mellom gammel og ny config, så denne branchen skal aldri merges. Grunnen til at jeg har lagd PR, er fordi github sin markdown har støtte for patch-notasjon som gjør at det er enkelt å lese diffen.

Så konfigen vi kommer til å ende opp med vil være seksjonert på filtype slik den orginalt er i dag 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants