Legg til vitest browser mode #6429
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| event.waitUntil(self.clients.claim()) | ||
| }) | ||
|
|
||
| self.addEventListener('message', async function (event) { | ||
| const clientId = event.source.id | ||
| addEventListener('message', async function (event) { |
Check warning
Code scanning / CodeQL
Missing origin verification in `postMessage` handler Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 8 days ago
To fix the issue, we need to verify the origin of the incoming message event to ensure it comes from a trusted source. This involves adding a check for the event.origin property against a list of allowed origins. If the origin is not trusted, the handler should return early without processing the message.
The fix will involve:
- Defining a list of trusted origins (e.g.,
const TRUSTED_ORIGINS = ['https://www.example.com'];). - Adding a conditional check at the beginning of the
messageevent handler to verify theevent.originagainst the trusted origins. - If the origin is not in the trusted list, the handler will return early.
Suggested changeset
1
public/mockServiceWorker.js
| @@ -23,2 +23,7 @@ | ||
| addEventListener('message', async function (event) { | ||
| const TRUSTED_ORIGINS = ['https://www.example.com']; | ||
| if (!TRUSTED_ORIGINS.includes(event.origin)) { | ||
| return; | ||
| } | ||
|
|
||
| const clientId = Reflect.get(event.source || {}, 'id') |
Copilot is powered by AI and may make mistakes. Always verify output.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mswTest må no brukast for testar som krev msw-handlers. Denne wrappar applyRequestHandlers som blir brukt av jsdom-testar, og setupWorker som må brukast for browser-mode.
Det er rundt 20-30 testar som feilar av ukjent årsak. Mange av desse køyrer ok om ein rekøyrer dei, så usikker på årsak. Håpar det ligg i vitest, men skal få sett meir på det etterkvart. Per no brukar me ikkje browser-mode i CI så det er ikkje krise at nokre testar feilar.
Så får me sjå om browser-mode blir nyttig. Forhåpentlegvis så vil det komme forbedringar i UI'et og kanskje ein bedre integrasjon i storybook. Evt bør me kanskje heller sjå på playwright eller play-funksjonaliteten i storybook