[Dialog] New component Dialog 🎉 #4262
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Halvor Haugan <[email protected]>
Co-authored-by: Halvor Haugan <[email protected]>
* 🎉 Track list of prev active elements * 🧪 track previous focused elements * Update @navikt/core/react/src/util/focus-boundary/FocusBoundary.tests.stories.tsx Co-authored-by: Halvor Haugan <[email protected]> * Update @navikt/core/react/src/util/focus-boundary/FocusBoundary.tsx Co-authored-by: Halvor Haugan <[email protected]> * Update @navikt/core/react/src/util/focus-boundary/FocusBoundary.tests.stories.tsx Co-authored-by: Halvor Haugan <[email protected]> * 🏷️ Rename button * ⚡ fall back to focusing trigger * 🎉 Now properly cleans up prev-focused items no longer possible to focus * 🐛 Update canvas-getby to use Role instead if id after component change * 🐛 Allow trap-focus without backdrop to close onPointerDown * 🔥 removed types * 🐛 Fall back to trigger focus on outside click in trap-focus mode --------- Co-authored-by: Halvor Haugan <[email protected]>
Comment on lines
100
to
112
| useEffect(() => { | ||
| if (parentContext?.nestedDialogOpened && open) { | ||
| parentContext.nestedDialogOpened(ownNestedOpenDialogs); | ||
| } | ||
| if (parentContext?.nestedDialogClosed && !open) { | ||
| parentContext.nestedDialogClosed(); | ||
| } | ||
| return () => { | ||
| if (parentContext?.nestedDialogClosed && open) { | ||
| parentContext.nestedDialogClosed(); | ||
| } | ||
| }; | ||
| }, [open, parentContext, ownNestedOpenDialogs]); |
Contributor
There was a problem hiding this comment.
I don't understand what you mean with "they are not the same".
- You don't have to check if both
nestedDialogOpenedandnestedDialogClosedare defined because they are both required. - When
openchanges tofalse, the cleanup function runs and callsnestedDialogClosed()since it checks the "old" version ofopen. Hence the call above (in theelse) is redundant. - Instead of checking
openinside the cleanup function, you can return the cleanup function ifopenis true.
Collaborator
Author
|
Ended up with useEffect(() => {
if (open && parentContext) {
parentContext.nestedDialogOpened(ownNestedOpenDialogs);
return () => parentContext.nestedDialogClosed();
}
}, [open, parentContext, ownNestedOpenDialogs]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now ready for initial round of reviews 🚀
TODOs
Tasks to do after first round of reviews and changes are made:
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")