-
Notifications
You must be signed in to change notification settings - Fork 7
Chore - Migrate react-native-render-html with history #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
5ZYSZ3K
wants to merge
1,420
commits into
main
Choose a base branch
from
chore/migrate-render-html-with-history
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful to customize the color, fontSize, fontFamily... etc.
Dependency upgrade fixes
Contributor
|
@5ZYSZ3K I converted to draft to make it clear this is a WIP. Please re-request for review when it's ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to: #13, just made with a source branch from this repo, to b able to preview targeting PRs in one place
Description
This PR is meant to move the contents of
react-native-render-htmlto this library with no other changesUltimately I decided to move
packages/render-htmlandappsdirectories to the repopackages/render-htmlcontains the core logic ofreact-native-render-htmlappscontains testing applications that may be helpfulI plan to create pull requests based off of this one to actually get it to work
References
Repository merge with history guide: https://gfscott.com/blog/merge-git-repos-and-keep-commit-history/
react-native-render-htmlrepo: https://github.com/meliorence/react-native-render-htmlRepository merge with history guide: https://gfscott.com/blog/merge-git-repos-and-keep-commit-history/
react-native-render-html repo: https://github.com/meliorence/react-native-render-html