Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game is now playable :) #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Dimillian
Copy link

No description provided.

@Dimillian
Copy link
Author

Wait, can you pass the first pipe on your version ? I only tried on iOS 7.1 b5. The whole point of my first commit is to make the game playable. You can ignore the indentation one. I can remake the pull request if you want.

@nathanborror
Copy link
Owner

I haven't tried it in 7.1—it all works fine in 7.0.4.

@Dimillian
Copy link
Author

Ahhhh, I tried in 7.1, pipes physic bodies was not right, I can not pass between them.

@Dimillian
Copy link
Author

Have a look: http://cl.ly/TqtB
I don't know if it's a bug or a change, anyway I had the same problem before with collision and scaled node.

@nathanborror
Copy link
Owner

That's weird, okay I'll install 7.1 and investigate.

@Dimillian
Copy link
Author

Okay, your method is far better than intersect, it's much faster. I'll investigate too, you might see another, better pull request when you wake up :) I'll not change the indention I promise.

@nathanborror
Copy link
Owner

Sweet thanks!

@Dimillian
Copy link
Author

Ultra weird: http://cl.ly/TrqM

@jbrooksuk
Copy link

If you take the bottom pipe out you'll notice that the bounding box of the top pipe is off, but only sometimes... I'm not sure what's causing it, but it seems to be when the image was introduced.

@Dimillian
Copy link
Author

The images is scaled and the physic body is not anymore the same size of the actual scaled image. I tried various things, none works. I don't know if it's a regression with iOS 7.1 or an evolution..

Also yes, with the current version the physics bodies are also a little wider than the node itself. Again, I think the YScaled images a big problem.

@jbrooksuk
Copy link

I wonder why the physicsBody doesn't stay in sync?

@Dimillian
Copy link
Author

@jbrooksuk
Copy link

That should be easy enough to implement then. It also explains why the box that bounds the node is sometimes bigger or smaller.

@Dimillian
Copy link
Author

Yeah, it need to be drawn manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants