-
Notifications
You must be signed in to change notification settings - Fork 18
Fix test failures #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test failures #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contributions. If you haven't already, please send a signed Contributor License Agreement (CLA) to Christopher Teubert ([email protected]). CLAs can be found here: https://github.com/nasa/progpy/tree/master/forms. Also, make sure you're familiar with the developer notes and contributing sections of our developers guide, https://nasa.github.io/progpy/dev_guide.html#notes-for-developers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything worked on my computer and completed code review. Good work
Note: Katy is finding some issues with package versions on her machine. She'll reach out separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice changes
7c94c48
to
65c5074
Compare
Address tests failures outlined in #181
tensorflow-macos
due to compatibility issue withnumpy>= 2.0.0
numpy
andnumpoly
when usingtensorflow-macos
(latest version 2.16.2)test_requirements.txt
progpy
import instead ofprog_algs
since they are merged in one package as noted in ProgPy v1.6 released #120