Skip to content

Fix test failures #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 24, 2025
Merged

Fix test failures #182

merged 6 commits into from
Feb 24, 2025

Conversation

lymichelle21
Copy link
Contributor

@lymichelle21 lymichelle21 commented Jan 31, 2025

Address tests failures outlined in #181

  • Remove tensorflow-macos due to compatibility issue with numpy>= 2.0.0
tensorflow 2.16.2 requires numpy<2.0.0,>=1.26.0; python_version >= "3.12", but you have numpy 2.2.2 which is incompatible.
    • Alternative would be to add dependency constraints on numpy and numpoly when using tensorflow-macos (latest version 2.16.2)
datadriven = [
    "tensorflow; platform_system!='Darwin' or platform_machine!='arm64'",
    "tensorflow-macos; platform_system=='Darwin' and platform_machine=='arm64'",
    "numpoly==1.2.12; platform_system=='Darwin' and platform_machine=='arm64'",
    "numpy<2.0.0,>=1.26.0; platform_system=='Darwin' and platform_machine=='arm64'"
]
  • Add optional dependencies for tests flag and remove test_requirements.txt
  • Use progpy import instead of prog_algs since they are merged in one package as noted in ProgPy v1.6 released #120

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions. If you haven't already, please send a signed Contributor License Agreement (CLA) to Christopher Teubert ([email protected]). CLAs can be found here: https://github.com/nasa/progpy/tree/master/forms. Also, make sure you're familiar with the developer notes and contributing sections of our developers guide, https://nasa.github.io/progpy/dev_guide.html#notes-for-developers

@teubert teubert requested review from teubert and kjjarvis February 5, 2025 18:14
Copy link
Contributor

@teubert teubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything worked on my computer and completed code review. Good work

@teubert
Copy link
Contributor

teubert commented Feb 10, 2025

Note: Katy is finding some issues with package versions on her machine. She'll reach out separately.

Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice changes

@teubert teubert merged commit a11cd92 into nasa:dev Feb 24, 2025
3 checks passed
@lymichelle21 lymichelle21 deleted the fix-tests branch March 17, 2025 14:59
@lymichelle21 lymichelle21 added bug Something isn't working tests Updates to tests, benchmarking or CI/CD infrastructure labels Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Updates to tests, benchmarking or CI/CD infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants