Event visualization composable #8007
Open
+286
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 7936-add-discrete-event-visualization #8007 +/- ##
=========================================================================
+ Coverage 57.02% 57.09% +0.07%
=========================================================================
Files 686 686
Lines 27783 27814 +31
Branches 2735 2731 -4
=========================================================================
+ Hits 15842 15880 +38
+ Misses 11596 11589 -7
Partials 345 345
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…b.com/nasa/openmct into event-visualization-composable
Co-authored-by: Even Stensberg <[email protected]>
| ></div> | ||
| <template v-if="lineData.enabled"> | ||
| <div | ||
| v-for="(line, index) in lineData.lines" |
There was a problem hiding this comment.
the index variable could have a more explicit name, like lineIndex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Describe your changes:
TODO:
Update yamcs and viper to exclude the extended lines bus from plugin.
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist