Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2641, Fixed Null Pointer in ES Application Control API test #2642

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmolock-NASA
Copy link

Checklist (Please check before submitting)

Describe the contribution

Updated the ES application control functional test for the CFE_ES_ReloadApp API to use an empty string instead of using a null pointer.

Fixes #2641

Testing performed

Built and executed the functional test and verified no failures detected in cfe_test.log file.

Expected behavior changes

No impact to behavior, functional test will execute as normal.

System(s) tested on

  • Hardware: PC
  • OS: RedHat 8

Contributor Info - All information REQUIRED for consideration of pull request
Dwaine Molock, NASA/GSFC

@dzbaker
Copy link
Collaborator

dzbaker commented Mar 6, 2025

CCB 6 March 2025: CFE_ES_ReloadApp() should check for NULL input as it is a public API. Change should be to function rather than unit test.

@dmolock-NASA
Copy link
Author

This change just fixes the current ES application control API functional test and prevents it from generating a memory segmentation fault depending on the GLIBC implementation.

The checking for a NULL pointer in the ES public API is a bigger issue, it will affect more than just CFE_ES_ReloadApp() function. There should be a ticket to verify that all public APIs that receive pointers perform a NULL pointer check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES application control functional test generates memory segmentation fault
2 participants