Addressing Issue#76. Adding start_date, end_date parameters to the _get_json_for_random_dates function. #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now function _get_json_for_random_dates accept a start_date and\or end_date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: #76
Extended function "_get_json_for_random_dates" to accept optional start_date and\or end_date parameters.
If only
start_dateis provided - thecurrent datewill be used as anend_date.if only
end_dateprovided -6/16/1995will be used as astart_date.The function will raise value error if:
countnumber exceeds the number of dates in the provided rangestart dateis after theend dateUpdated readme.md to reflect my changes.