-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nasa/cryptolib#441] WIP: Set Key, MC, SA, and Crypto type at compile time… #443
base: dev
Are you sure you want to change the base?
Conversation
…Lib into 441-streamline-crypto_config
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #443 +/- ##
==========================================
- Coverage 75.97% 75.79% -0.19%
==========================================
Files 81 80 -1
Lines 22263 22812 +549
Branches 1807 1845 +38
==========================================
+ Hits 16914 17290 +376
- Misses 4707 4850 +143
- Partials 642 672 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This causes every UT file to show errors, but it does work. Not sure if there is a way to ignore warnings for undefined constants |
We have been told that this type of "one crypto type, one key type, ..." is not ideal and they would like to be able to change. I believe this only affect unit tests, so this may still be ok. |
…, use those defines in UTs
All Submissions:
New Feature Submissions:
Changes to Core Features:
How do you test these changes?
This should allow every UT to run on every build type. You should be able to see each of the added build flags at the beginning of the build script step in CI.