Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/cryptolib#441] WIP: Set Key, MC, SA, and Crypto type at compile time… #443

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

Donnie-Ice
Copy link
Contributor

@Donnie-Ice Donnie-Ice commented Mar 26, 2025

…, use those defines in UTs

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

How do you test these changes?

This should allow every UT to run on every build type. You should be able to see each of the added build flags at the beginning of the build script step in CI.

@Donnie-Ice Donnie-Ice self-assigned this Mar 26, 2025
@Donnie-Ice Donnie-Ice linked an issue Mar 26, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 94.89051% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.79%. Comparing base (14ee573) to head (5e1ce87).
Report is 147 commits behind head on dev.

Files with missing lines Patch % Lines
test/unit/ut_sadb_err_cases_kmc_crypto.c 0.00% 4 Missing ⚠️
src/core/crypto_config.c 75.00% 1 Missing ⚠️
test/unit/ut_mysql_m_tls_connection.c 0.00% 1 Missing ⚠️
test/unit/ut_mysql_tls_connection.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #443      +/-   ##
==========================================
- Coverage   75.97%   75.79%   -0.19%     
==========================================
  Files          81       80       -1     
  Lines       22263    22812     +549     
  Branches     1807     1845      +38     
==========================================
+ Hits        16914    17290     +376     
- Misses       4707     4850     +143     
- Partials      642      672      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Donnie-Ice
Copy link
Contributor Author

This causes every UT file to show errors, but it does work. Not sure if there is a way to ignore warnings for undefined constants

@Donnie-Ice
Copy link
Contributor Author

We have been told that this type of "one crypto type, one key type, ..." is not ideal and they would like to be able to change. I believe this only affect unit tests, so this may still be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 Streamline Crypto_config
2 participants