Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WV-3504 Refine label placement #5719

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rboller
Copy link
Member

@rboller rboller commented Feb 21, 2025

Description

The latest release (v4.58.0) introduced vector tile-based reference labels using Esri vector tiles and a custom style. This PR links to a slightly updated style which refines label placement.

How To Test

  • git checkout WV-3504-updated-label-placement
  • npm i && npm run build:verbose
  • Validate that labels in the the reference labels layer are properly placed

PR Submission Checklist

This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been merged and published in downstream modules (if applicable)

Merging

Please use the squash and merge commit method unless each commit in your branch is vital to the commit history of main.

@nasa-gibs/worldview

@rboller rboller requested a review from minniewong February 21, 2025 18:58
@rboller rboller changed the base branch from main to develop February 21, 2025 18:59
@minniewong minniewong added this to the v4.59.0 milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants