-
Notifications
You must be signed in to change notification settings - Fork 162
feat: Spec'd-out CompliantExpr
#2119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
0a95012
chore(typing): Add alias to identify holes
dangotbanned b752965
feat(typing): Add all methods used in `expr.py`
dangotbanned 2b87d80
fix(typing): `map_batches` return type
dangotbanned 44f3c6f
feat(typing): add `Expr` namespaces
dangotbanned 01ea1b3
refactor: mark `ewm_mean` as unstable
dangotbanned 26b967f
fix: start adding `NotImplementedError`s
dangotbanned 39d6ced
fix(typing): add missing `[type-var]`
dangotbanned 4ca309c
fix: permit `over(keys=...)` widening
dangotbanned 0a93329
feat: replace boilerplate w/ `not_implemented` marker
dangotbanned 6a138dd
refactor: replace the other ones
dangotbanned 6b57795
feat(typing): mark all missing `DaskExpr`
dangotbanned 7622439
feat(typing): mark all missing `DuckDBExpr`
dangotbanned ccd68f5
feat(typing): mark all missing `SparkLikeExpr`
dangotbanned a1a1461
fix(typing): resolve more out-of-sync signatures
dangotbanned f8ef0c7
ignore pretty reasonable warning
dangotbanned b2c19e7
fix(typing): remove defaults from protocol
dangotbanned 6131455
test: add `test_not_implemented`
dangotbanned 50bcef0
feat: kinda resolve the `property` case
dangotbanned 427c8d9
docs: add "Returns"
dangotbanned fc02399
test: skip `duckdb` if not available
dangotbanned 31f3506
fix: unbreak doctest
dangotbanned 4c6b639
Merge branch 'main' into compliant-expr-spec
dangotbanned e599caa
Merge branch 'main' into compliant-expr-spec
dangotbanned 85a691c
Merge remote-tracking branch 'upstream/main' into compliant-expr-spec
dangotbanned d3bc414
refactor: Convert `DaskExpr.replace_strict` into `not_implemented`
dangotbanned 4804ab4
Merge remote-tracking branch 'upstream/main' into compliant-expr-spec
dangotbanned d8e32c0
feat(DRAFT): Add descriptor version `not_implemented_alt`
dangotbanned 85df827
typo
dangotbanned 88a073e
test: coverage for `@classmethod`-like?
dangotbanned 6784a12
feat(DRAFT): Improved `@property` support
dangotbanned 68b37d8
feat(DRAFT): Add a second option for `@property`
dangotbanned 50a9376
fix: coverage, fix alias
dangotbanned f64b466
Merge remote-tracking branch 'upstream/main' into compliant-expr-spec
dangotbanned fc0071c
Merge remote-tracking branch 'upstream/main' into compliant-expr-spec
dangotbanned 990ee7b
docs(DRAFT): Add IDE benefit demo video
dangotbanned f125b97
refactor: Fully replace original `not_implemented` callable
dangotbanned a076349
chore(typing): ignore pyright
dangotbanned 6928c1e
docs: Handle `not_implemented` in `generate_backend_completeness`
dangotbanned fae840f
Merge remote-tracking branch 'upstream/main' into compliant-expr-spec
dangotbanned b4caa96
Merge branch 'main' into compliant-expr-spec
dangotbanned a124302
chore: todo -> to-done
dangotbanned 7eab760
Merge branch 'compliant-expr-spec' of https://github.com/narwhals-devβ¦
dangotbanned 233ba14
style: tidy up whitespace
dangotbanned 3b24293
Merge branch 'main' into compliant-expr-spec
dangotbanned 7400a22
refactor: move `@deprecated` to `utils`
dangotbanned 400bbe4
docs: Finalize `unstable`, `not_implemented`
dangotbanned 885c16b
docs: add missing import
dangotbanned 7962cbb
revert: remove video
dangotbanned File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.