Use get_app_model instead of get_app for napari>=0.5.4
#103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jni
reviewed
Oct 23, 2024
| @@ -7,7 +7,7 @@ | |||
| from app_model.types import CommandRule, MenuItem | |||
|
|
|||
| # TODO: This will be made public in some future napari version | |||
| from napari._app_model import get_app | |||
| from napari._app_model import get_app_model | |||
There was a problem hiding this comment.
If we use a try-except here, we will be compatible with older versions of napari, before the deprecation:
Suggested change
| from napari._app_model import get_app_model | |
| try: | |
| from napari._app_model import get_app_model | |
| except ImportError: | |
| from napari._app_model import get_app as get_app_model |
@Czaki what do you think? Then I think we can just merge this and release?
There was a problem hiding this comment.
I prefer to use packaging and
from packaging.version import parse as parse_version
from importlib.metadata import version
if parse_version(version('napari')) >= parse_version('0.5.4'):
from napari._app_model import get_app_model
else:
from napari._app_model import get_app as get_app_modelIt allows for simpler found code that may be dropped when dropping support of older napari releases.
jni
reviewed
Oct 23, 2024
Co-authored-by: Juan Nunez-Iglesias <[email protected]>
Co-authored-by: Grzegorz Bokota <[email protected]>
dalthviz
force-pushed
the
napari_issue_6054
branch
from
eded23b to
4bf7497
Compare
Czaki
reviewed
Oct 23, 2024
| @@ -137,6 +137,8 @@ def test_zoom_and_dimensions(): | |||
| increase_dimensions_left(viewer) | |||
| increase_dimensions_right(viewer) | |||
|
|
|||
| viewer.close() | |||
There was a problem hiding this comment.
Maybe make_napari_viewer fixture?
jni
approved these changes
Nov 7, 2024
jni
changed the title
get_app_model instead of get_appget_app_model instead of get_app for napari>=0.5.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, as part of napari/napari#6054 usage of
get_appis being deprecated ( over PR napari/napari#7269 ). This PR changes things to useget_app_modelinstead ofget_app. It also bumps thenapariversion constraint to>=0.5.4