-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move user-facing information to top of preferences and fix autogenerated UI images #613
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TimMonko for another user-centered improvement. I love the user "how-to" before the preferences reference section. 💐
I noticed the screenshots dont match the headings, e.g. Application heading screenshot shows Appearance. I assume something was changed and this was never updated. Is there an easy way to get the screenshots in each Section? |
Going to link this issue: #13 |
Thanks for catching @psobolewskiPhD This is the code the makes the images:
Intuitively, it looks like it should be setting the file names correctly (the section header ends up as And as for the adding the screenshots to each section, I think that's doable, but I'm not sure if that is good value. Ultimately, I think like #13 we need to separate the user-facing component from the 'dev'-facing part of this, but that's a much bigger lift. |
@psobolewskiPhD thanks for the eyes! I've updated it and pretty sure I have it cleaned up now.
|
This is a huge improvement, so approving. |
Thanks. I understand where your are coming from. I think there are higher value things to work on for now, so we can save for later |
References and relevant issues
Description
get_settings()
is used to set a singleton was more important to my understanding)