-
-
Notifications
You must be signed in to change notification settings - Fork 114
[AtModem] Update IndexSSL for correct SSL context #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AtModem] Update IndexSSL for correct SSL context #1386
Conversation
Modified the `IndexSSL` constant in the `Sim7672HttpClient` class from `2` to `0`. This change ensures the correct SSL context ID is used for HTTP connections, as indicated by the updated comment. As of end march 2025 Azure doesn't negotiate the TLS anymore so we have to set it right.
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for all the work chasing the cause and fix. 👍🏻 💯
Waiting for the renewed code sign certificate to merge. |
@josesimoes Do I have to do anything? When will it be merged? |
We were waiting for some certificate work to be done. It seems that this work is done. So, we can merge now. Thanks again! |
Description
Motivation and Context
How Has This Been Tested?
I have tested this using the AtModem.Sample program.
The call to https://ikfu.azurewebsites.net/api/GetUtcTime/ now returnes the expected result.
Other calls remained working.
Screenshots
Types of changes
Checklist: