Skip to content

Add validation when setting linger option#410

Merged
josesimoes merged 1 commit into
nanoframework:mainfrom
josesimoes:fix-linger-set
Jul 10, 2026
Merged

Add validation when setting linger option#410
josesimoes merged 1 commit into
nanoframework:mainfrom
josesimoes:fix-linger-set

Conversation

@josesimoes

Copy link
Copy Markdown
Member

Description

  • Add content lenght validation.

Motivation and Context

  • Unlike what habpens in full .NET, this validation was missing. Now added.
  • Surfaced by existing unit test.

How Has This Been Tested?

  • Running unit tests locally.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@nfbot nfbot added the Type: bug Something isn't working label Jul 10, 2026
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@josesimoes, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository: nanoframework/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 13ac0c50-f131-4003-a2b9-d3da25fb563a

📥 Commits

Reviewing files that changed from the base of the PR and between 25d2755 and 40fc97b.

📒 Files selected for processing (1)
  • nanoFramework.System.Net/Sockets/Socket.cs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nfbot

nfbot commented Jul 10, 2026

Copy link
Copy Markdown
Member

⚠️ Native declaration update required!

The checksum and/or native version of nanoFramework.System.Net have changed. The native declaration in nf-interpreter must be updated before this package can be released.

Previously published This build
Native version 100.2.0.12 100.2.0.14
Checksum 0x6DFA71D6 0x8EFB9944

👉 Tracking issue: https://github.com/nanoframework/Home/issues/1818

The issue contains a link to the stubs artifact from this build and instructions for GitHub Copilot to perform the update.

@josesimoes
josesimoes merged commit afbdc5a into nanoframework:main Jul 10, 2026
7 checks passed
@josesimoes
josesimoes deleted the fix-linger-set branch July 10, 2026 15:57
josesimoes added a commit that referenced this pull request Jul 13, 2026
***NO_CI***

(cherry picked from commit afbdc5a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants