Fixes in several unit tests#409
Conversation
📝 WalkthroughWalkthroughSocket exception tests now accommodate additional platform error codes, use ChangesSocket exception tests
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Tests/SocketTests/SocketExceptionsTests.cs`:
- Around line 60-64: Restore specific ErrorCode validation in
SocketExceptionTest4_ProtocolNotSupported: capture the SocketException thrown by
the socket construction and assert its ErrorCode matches the expected
ProtocolNotSupported value, consistent with SocketExceptionTest3.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: nanoframework/coderabbit/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8c252bca-545d-414a-8976-1d5166df64ac
📒 Files selected for processing (1)
Tests/SocketTests/SocketExceptionsTests.cs
- Fix exception in ProtocolNotSupported. - Fix address not available test. - Fixed wrong asserts. - Closing sockets from tests now so that pool is not starved before test group ends.
d079f8a to
4545eb7
Compare
***NO_CI*** (cherry picked from commit 7e0da48)
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist: