Skip to content

Fix NetworkHelper re-entry guard and add Reset()#398

Closed
josesimoes wants to merge 1 commit into
developfrom
cherry-pick-397
Closed

Fix NetworkHelper re-entry guard and add Reset()#398
josesimoes wants to merge 1 commit into
developfrom
cherry-pick-397

Conversation

@josesimoes

Copy link
Copy Markdown
Member

Description

(cherry picked from commit 32e2b7e)

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: nanoframework/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: e4f5f453-f6f6-4447-91b3-79915f0d9139

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@josesimoes josesimoes closed this May 29, 2026
@nfbot nfbot added invalid This doesn't seem right and removed Type: bug Something isn't working Type: enhancement New feature or request Type: documentation Breaking-Change Type: Unit Tests labels May 29, 2026
@josesimoes josesimoes deleted the cherry-pick-397 branch May 29, 2026 14:46
@josesimoes josesimoes restored the cherry-pick-397 branch July 9, 2026 23:34
@josesimoes josesimoes changed the title Fix NetworkHelper re-entry guard and add Reset() (#397) Fix NetworkHelper re-entry guard and add Reset() Jul 9, 2026
@josesimoes josesimoes deleted the cherry-pick-397 branch July 14, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking-Change invalid This doesn't seem right Type: bug Something isn't working Type: documentation Type: enhancement New feature or request Type: Unit Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants