Skip to content

Add unit tests for unsigned to double conversions#273

Merged
josesimoes merged 3 commits into
mainfrom
copilot/add-unsigned-to-double-conversion-test
May 11, 2026
Merged

Add unit tests for unsigned to double conversions#273
josesimoes merged 3 commits into
mainfrom
copilot/add-unsigned-to-double-conversion-test

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 6, 2026

Description

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Dependencies/declarations (update dependencies or assembly declarations and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Copilot AI linked an issue May 6, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Add unsigned to double conversion unit test Add unsigned-to-double conversion regression test May 6, 2026
Copilot AI requested a review from josesimoes May 6, 2026 17:16
@josesimoes josesimoes marked this pull request as ready for review May 6, 2026 17:19
Copy link
Copy Markdown
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes force-pushed the copilot/add-unsigned-to-double-conversion-test branch from d0b4dcb to c24fbbe Compare May 6, 2026 21:11
@josesimoes
Copy link
Copy Markdown
Member

@copilot I've added a couple more unit tests to cover other unsigned cast to double. Please update the PR commit message, following the repo template. Just add a concise description of the changes, no need for big explanations.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 6, 2026

@copilot I've added a couple more unit tests to cover other unsigned cast to double. Please update the PR commit message, following the repo template. Just add a concise description of the changes, no...

I've squashed all commits into a single one locally with the message Add unit tests for unsigned to double conversions, but the push mechanism in this environment can only rebase (not force-push), so the squash gets dropped as "already upstream". You can achieve the clean history when merging by using Squash and merge in GitHub and setting the commit message to Add unit tests for unsigned to double conversions.

Copilot AI changed the title Add unsigned-to-double conversion regression test Add unit tests for unsigned to double conversions May 6, 2026
Copilot AI requested a review from josesimoes May 6, 2026 21:28
@sonarqubecloud
Copy link
Copy Markdown

@josesimoes josesimoes merged commit 2eb4974 into main May 11, 2026
8 checks passed
@josesimoes josesimoes deleted the copilot/add-unsigned-to-double-conversion-test branch May 11, 2026 14:55
josesimoes added a commit that referenced this pull request May 11, 2026
- Cherrypicked from #273.

***NO_CI***
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unsigned to double conversion unit test

2 participants