[#977] feat: Add support for dynamic item sizing and vertical gap in … #978
+43
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #977
Adds support for dynamic item sizing and improves vertical gap control in the timeline component.
Overview
Dynamic item height
This pull request introduces dynamic item height support in the timeline component. Each item can define its height, controlled at the item level through a new optional
heightprop.The layout calculations, including group height, item positioning, and collision detection, have been updated to account for these per-item height values.
Consistent vertical gap
Additionally,
itemVerticalGaptimeline prop has been added to maintain consistent vertical spacing between items of varying heights, replacing the previousitemHeightRatiobased gap logic for dynamic scenarios.