fix: Externalize dayjs dependency #965
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dayjs dependency in `external` rollup configuration option. As it is a peer dependency it shouldn't be included in the bundle. Consuming applications have to add dayjs as a dependency. This also allows changing locale in consuming applications.
The devDependency is not needed [As of npm v7, peerDependencies are installed by default.](https://docs.npmjs.com/cli/v11/configuring-npm/package-json#:~:text=As%20of%20npm%20v7%2C%20peerDependencies%20are%20installed%20by%20default.). npm v7 and higher is included in node>=15
Ilaiwi
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dayjs dependency in
externalrollup configuration option. As it is a peer dependency it shouldn't be included in the bundle.Consuming applications have to add dayjs as a dependency. This also allows changing locale in consuming applications.
Issue Number
Fixes #964. This allows using a dayjs locale other than English in consuming applications so the dates in the Timeline header (months, days of week) use this locale.
Overview of PR
Add the dayjs in rollup's
externalconfiguration option.Remove dayjs devDependency and use its version in the peerDependency.
The devDependency is thus not needed As of npm v7, peerDependencies are installed by default. npm v7 and higher is included in node>=15 and since node 20 is the lowest maintained version it will be safe to remove it.