Issue 500 diagonal scroll trackpad #873
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Allows for y mouse movement checking
|
The |
|
oops, this was supposed to be a draft! |
…prevents confusion and bugs when a touchpad scroll is a diagonal
…read the windows current x position since x is not being modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: 500
Link to issue
I restored the code from v0.21.0 and it has restored the functionality of touch pad diagonal scrolling. It does seem that on most browser you must initially move your fingers in a diagonal motion because scrolling seems to be locked to the initial direction of scrolling per event.
I have added a small bit of code so that when clicking inside the calendar component it can be dragged on the X and Y axis. To do this I turned
dragStartPositioninto an object containingxandyscroll values. I then usedragStartPosition.yto update the windows scroll position.I also fixed a bug with the shiftKey modifier when scrolling. deltaY was prioritized in a ternary resulting in glitchy and confusing movement when touchpad scrolling was diagonal. deltaX is now prioritized.