Skip to content

Commit

Permalink
send-email-challenge: make smtp_user/smtp_password optional in config
Browse files Browse the repository at this point in the history
Change-Id: If22a86f878225e97f231e081081aef04b81bef93
  • Loading branch information
Pesa committed Jan 5, 2025
1 parent 397faa9 commit 74f837d
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 17 deletions.
14 changes: 9 additions & 5 deletions ndncert-mail.conf.sample
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
[ndncert.smtp]
SMTP_SERVER = localhost or remote smtp server
SMTP_PORT = port number, usually one from 25 465 587
ENCRYPT_MODE = select one from ssl/starttls/none
SMTP_USER = leave it empty if you do not have one
SMTP_PASSWORD = leave it empty if you do not have one
# Address or hostname of SMTP server
smtp_server =
# SMTP server port number; usually 25, 465, or 587
smtp_port =
# One of ssl/starttls/none
encrypt_mode =
# Optional username and password for SMTP authentication
#smtp_user =
#smtp_password =

[ndncert.email]
from = NDN Certificate Robot <[email protected]>
Expand Down
24 changes: 12 additions & 12 deletions ndncert-send-email-challenge.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,22 @@
}

# open config file
confParser = configparser.ConfigParser(empty_lines_in_values=True,
interpolation=configparser.ExtendedInterpolation())
confParser.read('@SYSCONFDIR@/ndncert/ndncert-mail.conf')
cfg = configparser.ConfigParser(empty_lines_in_values=True,
interpolation=configparser.ExtendedInterpolation())
cfg.read('@SYSCONFDIR@/ndncert/ndncert-mail.conf')

# read smtp settings
encrypt_mode = confParser.get('ndncert.smtp', 'encrypt_mode')
server = confParser.get('ndncert.smtp', 'smtp_server')
port = confParser.get('ndncert.smtp', 'smtp_port')
username = confParser.get('ndncert.smtp', 'smtp_user')
password = confParser.get('ndncert.smtp', 'smtp_password')
server = cfg.get('ndncert.smtp', 'smtp_server')
port = cfg.get('ndncert.smtp', 'smtp_port')
encrypt_mode = cfg.get('ndncert.smtp', 'encrypt_mode')
username = cfg.get('ndncert.smtp', 'smtp_user', fallback=None)
password = cfg.get('ndncert.smtp', 'smtp_password', fallback=None)

# read email settings
from_addr = confParser.get('ndncert.email', 'from', vars=vars)
subject = confParser.get('ndncert.email', 'subject', vars=vars)
text = confParser.get('ndncert.email', 'text_template', vars=vars)
html = confParser.get('ndncert.email', 'html_template', vars=vars)
from_addr = cfg.get('ndncert.email', 'from', vars=vars)
subject = cfg.get('ndncert.email', 'subject', vars=vars)
text = cfg.get('ndncert.email', 'text_template', vars=vars)
html = cfg.get('ndncert.email', 'html_template', vars=vars)

# create email message
msg = EmailMessage()
Expand Down

0 comments on commit 74f837d

Please sign in to comment.