Add span! macro #21
Closed
Add span! macro #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be awesome to have!
Sounds like a good plan to me. |
nagisa
approved these changes
Sep 18, 2021
| fn f() {} | ||
| fn type_name_of<T>(_: T) -> &'static str { | ||
| std::any::type_name::<T>() | ||
| } |
There was a problem hiding this comment.
From what I can tell this can be simplified to a
struct S;
let func_name = std::any::type_name::<S>();
let function = &func_name[..func_name.len() - 3];
|
Would be great if you could add a test that just calls the macro as well as bump the version of rustc in CI files to something like 1.52 or 1.53. |
|
Merged in f06d0fd Thanks! |
|
Awesome! Any chance of a patch release with this in it soon? |
|
Yeah I have been meaning to make some other changes too but I guess i can
just split them up.
…On Sat, 18 Sep 2021, 20:57 Benjamin Saunders, ***@***.***> wrote:
Awesome! Any chance of a patch release with this in it soon?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFFZUWNAFVWNJOSCEZ6IJDUCTHHZANCNFSM5DPR3HTQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Looks like we're seeing some SIGSEGVs on Windows in a doctest I added for the macro, which I'll need to investigate before I cut a release. |
|
Could not reproduce the issue locally and I bet its not a new failure mode anyway, so went ahead and published 0.12.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro uses
file!()andline!()to determine the file name and line number to pass toSpan::new(...). It also uses a hack to determine the function name, which is the same hack used instdext::function_name!, since the RFC to add a macro for this to the Rust stdlib is unresolved.Alternatively,
stdextcould be added as a dependency, but that's probably overkill.Also, it might be convenient to support omitting the
callstack_depthwith a default value of 62, which is the max according to Tracy documentation ("The maximum call stack depth that can be retrieved is 62 frames. This is a restriction at the level of operating system.").