SipRtpEndpoint: add support for external IP config option#3
Open
dpocock wants to merge 15 commits intonaevatec:masterfrom
Open
SipRtpEndpoint: add support for external IP config option#3dpocock wants to merge 15 commits intonaevatec:masterfrom
dpocock wants to merge 15 commits intonaevatec:masterfrom
Conversation
sync to 6.13 origin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on the following change in kms-core
https://github.com/Kurento/kms-core/pull/28/files?diff=unified&w=1
This was submitted as a pull request against kms-elements adding the external IP config option
https://github.com/Kurento/kms-elements/pull/36/files?diff=unified&w=1
I've adapted the patch for your branch and added the code to
kms_sip_rtp_endpoint_set_addrso that theSipRtpEndpointwill use the same config setting.The Kurento pre-commit
indentcheck has made many whitespace changes. I only changed approximately 5 lines in the methodkms_sip_rtp_endpoint_set_addr. You can click the "Hide whitespace" option in Github to make it easier to see the real changes here.