Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📦 NEW: add discover options #752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

📦 NEW: add discover options #752

wants to merge 1 commit into from

Conversation

IvanWhisper
Copy link

add discover options

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

joseph seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

binbin0325
binbin0325 requested changes May 14, 2024
View reviewed changes
Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以新建一个issue，详细描述下 当前pr要解决的需求或问题。

@IvanWhisper
Copy link
Author

IvanWhisper commented May 14, 2024 via email

binbin0325
binbin0325 reviewed May 27, 2024
View reviewed changes
Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议参考INamingClient 中的 SelectInstances，SelectAllInstances 等实现方式，保持用法一致。便于用户理解

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binbin0325 binbin0325 binbin0325 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanWhisper @CLAassistant @binbin0325