Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature.Make client auth service pluggable. #505

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sivyer9303
Copy link
Contributor

see #458

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 52.63158% with 27 lines in your changes missing coverage. Please review.

Project coverage is 29.93%. Comparing base (b5986f7) to head (fff5e60).
Report is 78 commits behind head on master.

Files with missing lines Patch % Lines
common/security/security_delegate.go 73.17% 6 Missing and 5 partials ⚠️
common/nacos_server/nacos_server.go 0.00% 10 Missing ⚠️
common/security/security_proxy.go 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
- Coverage   30.14%   29.93%   -0.21%     
==========================================
  Files          40       42       +2     
  Lines        2913     3033     +120     
==========================================
+ Hits          878      908      +30     
- Misses       1971     2056      +85     
- Partials       64       69       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants