Skip to content

Commit

Permalink
update SearchConfigParam (#535)
Browse files Browse the repository at this point in the history
  • Loading branch information
binbin0325 authored Oct 29, 2022
1 parent cad5a5e commit a13f6f2
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 11 deletions.
6 changes: 3 additions & 3 deletions clients/config_client/config_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ func (client *ConfigClient) DeleteConfig(param vo.ConfigParam) (deleted bool, er
return false, err
}

//Cancel Listen Config
// Cancel Listen Config
func (client *ConfigClient) CancelListenConfig(param vo.ConfigParam) (err error) {
clientConfig, err := client.GetClientConfig()
if err != nil {
Expand Down Expand Up @@ -324,7 +324,7 @@ func (client *ConfigClient) ListenConfig(param vo.ConfigParam) (err error) {
return
}

func (client *ConfigClient) SearchConfig(param vo.SearchConfigParm) (*model.ConfigPage, error) {
func (client *ConfigClient) SearchConfig(param vo.SearchConfigParam) (*model.ConfigPage, error) {
return client.searchConfigInner(param)
}

Expand All @@ -333,7 +333,7 @@ func (client *ConfigClient) CloseClient() {
client.cancel()
}

func (client *ConfigClient) searchConfigInner(param vo.SearchConfigParm) (*model.ConfigPage, error) {
func (client *ConfigClient) searchConfigInner(param vo.SearchConfigParam) (*model.ConfigPage, error) {
if param.Search != "accurate" && param.Search != "blur" {
return nil, errors.New("[client.searchConfigInner] param.search must be accurate or blur")
}
Expand Down
2 changes: 1 addition & 1 deletion clients/config_client/config_client_interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ type IConfigClient interface {
// tenant ==>nacos.namespace optional
// pageNo option,default is 1
// pageSize option,default is 10
SearchConfig(param vo.SearchConfigParm) (*model.ConfigPage, error)
SearchConfig(param vo.SearchConfigParam) (*model.ConfigPage, error)

// CloseClient Close the GRPC client
CloseClient()
Expand Down
4 changes: 2 additions & 2 deletions clients/config_client/config_client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func (m *MockConfigProxy) queryConfig(dataId, group, tenant string, timeout uint
}
return &rpc_response.ConfigQueryResponse{Content: "hello world"}, nil
}
func (m *MockConfigProxy) searchConfigProxy(param vo.SearchConfigParm, tenant, accessKey, secretKey string) (*model.ConfigPage, error) {
func (m *MockConfigProxy) searchConfigProxy(param vo.SearchConfigParam, tenant, accessKey, secretKey string) (*model.ConfigPage, error) {
return &model.ConfigPage{TotalCount: 1}, nil
}
func (m *MockConfigProxy) requestProxy(rpcClient *rpc.RpcClient, request rpc_request.IRequest, timeoutMills uint64) (rpc_response.IResponse, error) {
Expand Down Expand Up @@ -106,7 +106,7 @@ func Test_SearchConfig(t *testing.T) {
DataId: localConfigTest.DataId,
Group: "DEFAULT_GROUP",
Content: "hello world"})
configPage, err := client.SearchConfig(vo.SearchConfigParm{
configPage, err := client.SearchConfig(vo.SearchConfigParam{
Search: "accurate",
DataId: localConfigTest.DataId,
Group: "DEFAULT_GROUP",
Expand Down
2 changes: 1 addition & 1 deletion clients/config_client/config_proxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func (cp *ConfigProxy) injectCommHeader(param map[string]string) {
param[constant.CHARSET_KEY] = "utf-8"
}

func (cp *ConfigProxy) searchConfigProxy(param vo.SearchConfigParm, tenant, accessKey, secretKey string) (*model.ConfigPage, error) {
func (cp *ConfigProxy) searchConfigProxy(param vo.SearchConfigParam, tenant, accessKey, secretKey string) (*model.ConfigPage, error) {
params := util.TransformObject2Param(param)
if len(tenant) > 0 {
params["tenant"] = tenant
Expand Down
2 changes: 1 addition & 1 deletion clients/config_client/config_proxy_interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (

type IConfigProxy interface {
queryConfig(dataId, group, tenant string, timeout uint64, notify bool, client *ConfigClient) (*rpc_response.ConfigQueryResponse, error)
searchConfigProxy(param vo.SearchConfigParm, tenant, accessKey, secretKey string) (*model.ConfigPage, error)
searchConfigProxy(param vo.SearchConfigParam, tenant, accessKey, secretKey string) (*model.ConfigPage, error)
requestProxy(rpcClient *rpc.RpcClient, request rpc_request.IRequest, timeoutMills uint64) (rpc_response.IResponse, error)
createRpcClient(ctx context.Context, taskId string, client *ConfigClient) *rpc.RpcClient
getRpcClient(client *ConfigClient) *rpc.RpcClient
Expand Down
2 changes: 1 addition & 1 deletion common/constant/const.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ const (
KEY_BEAT = "beat"
KEY_DOM = "dom"
DEFAULT_CONTEXT_PATH = "/nacos"
CLIENT_VERSION = "Nacos-Go-Client:v2.1.1"
CLIENT_VERSION = "Nacos-Go-Client:v2.1.2"
REQUEST_DOMAIN_RETRY_TIME = 3
SERVICE_INFO_SPLITER = "@@"
CONFIG_INFO_SPLITER = "@@"
Expand Down
2 changes: 1 addition & 1 deletion example/config/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func main() {
})
time.Sleep(1 * time.Second)

searchPage, _ := client.SearchConfig(vo.SearchConfigParm{
searchPage, _ := client.SearchConfig(vo.SearchConfigParam{
Search: "blur",
DataId: "",
Group: "",
Expand Down
2 changes: 1 addition & 1 deletion vo/config_param.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ type ConfigParam struct {
OnChange func(namespace, group, dataId, data string)
}

type SearchConfigParm struct {
type SearchConfigParam struct {
Search string `param:"search"`
DataId string `param:"dataId"`
Group string `param:"group"`
Expand Down

0 comments on commit a13f6f2

Please sign in to comment.