-
-
Notifications
You must be signed in to change notification settings - Fork 993
Refactor getPath()
to path()
for Consistent Getter Naming
#2066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
solomon-ochepa
wants to merge
12
commits into
nWidart:master
Choose a base branch
from
solomon-ochepa:refactor-getPath-to-path-for-consistent-getter-naming
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactor getPath()
to path()
for Consistent Getter Naming
#2066
solomon-ochepa
wants to merge
12
commits into
nWidart:master
from
solomon-ochepa:refactor-getPath-to-path-for-consistent-getter-naming
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… methods - [test] Enhance PathNamespaceTest with additional path and namespace conversion tests - [feat] add module_path and module_app_path methods for improved module path handling - [refactor] fix trimming logic in clean() method for improved path handling - [fix] trim leading and trailing slashes in app path for consistency - [refactor] enhance path handling methods for improved clarity and consistency
…ing PathNamespace's path method
…path()` for consistent naming convention and method usage - Updated method calls from `getPath()` to `path()` in SeedCommand, ActionMakeCommand, CastMakeCommand, ChannelMakeCommand, ClassMakeCommand, CommandMakeCommand, ComponentClassMakeCommand, ComponentViewMakeCommand, ControllerMakeCommand, EnumMakeCommand, EventMakeCommand, EventProviderMakeCommand, ExceptionMakeCommand, FactoryMakeCommand, HelperMakeCommand, InterfaceMakeCommand, JobMakeCommand, ListenerMakeCommand, MailMakeCommand, MiddlewareMakeCommand, ModelMakeCommand, NotificationMakeCommand, ObserverMakeCommand, PolicyMakeCommand, ProviderMakeCommand, RepositoryMakeCommand, RequestMakeCommand, ResourceMakeCommand, RouteProviderMakeCommand, RuleMakeCommand, ScopeMakeCommand, SeedMakeCommand, ServiceMakeCommand, TestMakeCommand, TraitMakeCommand, ViewMakeCommand, and ModuleGenerator. - Adjusted tests in GenerateConfigReaderTest to reflect the updated method names. - Improved consistency and clarity in path handling across the module generation commands.
… - replace `getPath()` with `path()` for consistent naming convention and method usage
…or consistent naming convention and method usage
…)` for consistent naming convention and method usage
…or consistent naming convention and method usage
…precate old path methods for consistency
…iable and update assertions to use module_app_path method
…nd update path assertions for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all instances of the
getPath()
method topath()
across the codebase to align with the KISS Principle's standard naming conventions for getter methods. All method definitions and usages have been updated accordingly.The goal is to ensure consistency, improve readability, and maintain a uniform approach to accessor methods throughout the application.
Changes Made:
getPath()
method topath()
in all affected classes.path()
instead ofgetPath()
.getPath()
usages exist.Test Instructions:
path()
method.Related: