Skip to content

Refactor getPath() to path() for Consistent Getter Naming #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

solomon-ochepa
Copy link
Contributor

@solomon-ochepa solomon-ochepa commented May 9, 2025

This PR updates all instances of the getPath() method to path() across the codebase to align with the KISS Principle's standard naming conventions for getter methods. All method definitions and usages have been updated accordingly.

The goal is to ensure consistency, improve readability, and maintain a uniform approach to accessor methods throughout the application.

Changes Made:

  • Renamed getPath() method to path() in all affected classes.
  • Updated all references and method calls to use path() instead of getPath().
  • Verified and ensured all tests passed successfully.
  • Confirmed no remaining getPath() usages exist.

Test Instructions:

  • Run the full test suite to ensure all functionality remains intact.
  • Manually test affected features (if any) that rely on the path() method.

Related:

  • solomon-ochepa:fix-issues-with-app-path-and-namespace

… methods

- [test] Enhance PathNamespaceTest with additional path and namespace conversion tests
- [feat] add module_path and module_app_path methods for improved module path handling
- [refactor] fix trimming logic in clean() method for improved path handling
- [fix] trim leading and trailing slashes in app path for consistency
- [refactor] enhance path handling methods for improved clarity and consistency
…path()` for consistent naming convention and method usage

- Updated method calls from `getPath()` to `path()` in SeedCommand, ActionMakeCommand, CastMakeCommand, ChannelMakeCommand, ClassMakeCommand, CommandMakeCommand, ComponentClassMakeCommand, ComponentViewMakeCommand, ControllerMakeCommand, EnumMakeCommand, EventMakeCommand, EventProviderMakeCommand, ExceptionMakeCommand, FactoryMakeCommand, HelperMakeCommand, InterfaceMakeCommand, JobMakeCommand, ListenerMakeCommand, MailMakeCommand, MiddlewareMakeCommand, ModelMakeCommand, NotificationMakeCommand, ObserverMakeCommand, PolicyMakeCommand, ProviderMakeCommand, RepositoryMakeCommand, RequestMakeCommand, ResourceMakeCommand, RouteProviderMakeCommand, RuleMakeCommand, ScopeMakeCommand, SeedMakeCommand, ServiceMakeCommand, TestMakeCommand, TraitMakeCommand, ViewMakeCommand, and ModuleGenerator.
- Adjusted tests in GenerateConfigReaderTest to reflect the updated method names.
- Improved consistency and clarity in path handling across the module generation commands.
… - replace `getPath()` with `path()` for consistent naming convention and method usage
…or consistent naming convention and method usage
…)` for consistent naming convention and method usage
…or consistent naming convention and method usage
…iable and update assertions to use module_app_path method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant