Fix several SVG images #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged behavior, but might as well change to serif font first.
… example is still far from perfect....
|
Also of note is that it replaces non-NotoSerif source fonts with NotoSerif where available. That's mainly because the monoline style in Noto Sans can make it harder to distinguish between bases and marks. Plus, in a few cases, there were some non-Noto fonts used because the contemporary Notos didn't have the necessary features to show off, and dropping those for Noto just simplifies the font-scavenging step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #166, this fixes up a significant number of the broken SVG illustrations.
Currently there are some outstanding ones (namely in Tibetan, Mongolian, and Syriac, which are more difficult to trace GSUB/GPOS from for finding example sequences — and emoji, which may be better off as PNG anyhow).
I'm inclined to merge it in quickly, though, since it's about breakage.