[WIP] Indic: Flag glyphs for features after initial reorder #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le feature applications after initial reordering.
adrianwong
reviewed
Aug 3, 2020
…ee issue #104 and discussion at #101 (comment) for background re the intended scope of init.
… link-error in chartable markdown.
…nicode ISC data, as per HarfBuzz.
Merging the numerals-as-placeholders change for Indic2.
…le feature applications after initial reordering.
…ee issue #104 and discussion at #101 (comment) for background re the intended scope of init.
…type-shaping-documents into flag-feature-masks
|
Taking a breather before merging this, since I still don't understand why GitHub rebasing & git rebasing don't work the same way, and I want to give it another look with fresh eyes (because all the catch-up commits cloud it a tad). But there's nothing new here; it's just completing the Stage 2, Step 10 "flag possible feature applications" for Indic2. |
|
Thanks for your good work, @n8willis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate patch to #89 to explicitly tell shapers to flag glyphs for possible feature applications after initial reordering. As in issue #71.
It adds this as a separate step (2.10), so it should be easier to reference. It also changes the verb used for this stuff to "flag", just so that we're not overloading "tag" even more.
Seems better to me, for both reasons, but a second pair of eyes is more than welcome. Not sure if it helps or hurts to mention GPOS and the stylistic GSUB features, since it looks like implementations don't carry masks for those.