hack: Prioritise UDP disco messages #3237
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help with disco messages being dropped because the AsyncUdpSocket is hogging the socket's internal lock because it being asked to send so much data. The unbounded queue is essentially bounded by the concurrency of the writers to the socket, so will stay small.
flub
commented
Mar 17, 2025
| @@ -1783,7 +1860,7 @@ impl Handle { | |||
| let _ = actor_tasks.spawn({ | |||
| let msock = msock.clone(); | |||
| async move { | |||
| while let Some((dst, dst_key, msg)) = udp_disco_receiver.recv().await { | |||
| while let Ok((dst, dst_key, msg)) = udp_disco_receiver.recv().await { | |||
There was a problem hiding this comment.
So this task was previously the only place which would send these queued disco messages. Internally in the actual socket it is taking a lock which is contended with the same socket with the same internal lock that is called from try_send whcih is modified above to also read from this same udp_disco_receiver now.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3237/docs/iroh/ Last updated: 2025-03-17T18:28:02Z |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should help with disco messages being dropped because the AsyncUdpSocket is hogging the socket's internal lock because it being asked to send so much data.
The unbounded queue is essentially bounded by the concurrency of the writers to the socket, so will stay small.
Breaking Changes
Notes & open questions
The code duplication, the unbounded queue (which is bounded really).... It's a quick hack right now. Though I'm not sure how nice it can be made right now.
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme