Skip to content

feat: Use reflink_or_copy for export as well #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2025
+58 −14
Merged

feat: Use reflink_or_copy for export as well #137

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0374408
Use reflink_or_copy for export as well
rklaehn Aug 20, 2025
76236c1
cargo deny
rklaehn Aug 21, 2025
7657336
Add reflink_or_copy_with_progress and use it from both import and export
rklaehn Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/store/fs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,9 +1263,18 @@ async fn export_path_impl(
}
MemOrFile::File((source_path, size)) => match mode {
ExportMode::Copy => {
let source = fs::File::open(&source_path)?;
let mut target = fs::File::create(&target)?;
copy_with_progress(&source, size, &mut target, tx).await?
tx.try_send(ExportProgressItem::CopyProgress(0))
.await
.map_err(|_e| io::Error::other(""))?;
let written = reflink_copy::reflink_or_copy(&source_path, &target)?;
if let Some(written) = written {
if written != size {
return Err(io::Error::other(format!(
"wrote {written} bytes, expected {size}",
))
.into());
}
}
}
ExportMode::TryReference => {
match std::fs::rename(&source_path, &target) {
Expand Down
Loading