deps: bump to iroh@main and irpc@main #128
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/128/docs/iroh_blobs/ Last updated: 2025-07-29T12:58:24Z |
src/api.rs
Outdated
| Request::ClearProtected(msg) => local.send((msg, tx)), | ||
| Request::SyncDb(msg) => local.send((msg, tx)), | ||
| Request::Shutdown(msg) => local.send((msg, tx)), | ||
| BlobsApi::SetTag(msg) => local.send((msg, tx)), |
There was a problem hiding this comment.
Was this forwarder boilerplate one of the things we can get rid of with the new features of the macro?
Just curious, perfectly reasonable to do this in a subsequent PR.
There was a problem hiding this comment.
Yup! Removed in the latest commit.
src/api/proto.rs
Outdated
| #[derive(Debug, Serialize, Deserialize)] | ||
| pub enum Request { | ||
| pub enum BlobsApi { |
There was a problem hiding this comment.
Not quite sure about this rename. Request as the enum of all possible serializable requests seems fine. And calling it BlobsApi creates a bit of confusion with the api module that has the actual friendly api.
There was a problem hiding this comment.
Don't mind much. Renamed back to Request. As most things are not public that use this it's fine. My initial rename was from seeing irpc::Client<Request> and thinking "maybe better to rename to something that contains Blobs". But as this is all private it really is fine as it is.
|
I think since the proto module is hidden but public, due to the rename there are breaking changes. |
Description
This bumps irpc to the (not yet released) main version, adapting for the breaking changes introduced in n0-computer/irpc#46.
Breaking Changes
iroh_blobs::api::proto::StoreServiceis removed,Requestnow implementsirpc::Serviceiroh_blobs::api::downloader::DownloaderServiceis removed,SwarmProtocolnow implementsirpc::ServiceNotes & open questions
Change checklist