SSR support added #193
Open
SSR support added #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First and foremost, thank you for your library. It has proven to be extremely useful.
While implementing Angular SSR (Server-Side Rendering) with @angular-devkit/build-angular:application, we encountered the same issue reported in #159 and #50.
In addition to resolving the "document not defined" error, I found it noteworthy that the SSR functionality appends the tag immediately after the tag, in accordance with Google's recommendations.
Regarding my contribution, I've made modifications to the addGtmToDom function to differentiate between PlatformServer and PlatformBrowser. Drawing inspiration from the code snippet provided in the Angular Platform Browser's meta service, I incorporated logic to include the tag (as seen here) within the DOM object for SSR scenarios.