Innodb fragmented plugin #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frederic Descamps <[email protected]>
Signed-off-by: Frederic Descamps <[email protected]>
grypyrg
reviewed
Jul 8, 2019
innodb/fragmented.py
Outdated
| CONCAT(round(data_free/(data_length+index_length)*100,2),'%'), | ||
| '100%'),')') AS data_free_pct | ||
| FROM information_schema.TABLES WHERE (data_free/(data_length+index_length)*100) > {limit} | ||
| AND table_schema <> 'mysql';""".format(limit=percent) |
There was a problem hiding this comment.
add AND ENGINE="INNODB" :)
innodb/fragmented.py
Outdated
| CONCAT(ROUND(index_length / ( 1024 * 1024 * 1024 ), 2), 'G') IDX, | ||
| CONCAT(ROUND(( data_length + index_length ) / ( 1024 * 1024 * 1024 ), 2), 'G') 'TOTAL SIZE', | ||
| ROUND(index_length / data_length, 2) IDXFRAC, | ||
| CONCAT(ROUND(( data_free / 1024 / 1024),2), 'MB') AS data_free, |
There was a problem hiding this comment.
Consistent column names would be nice
TABLE
TOTAL SIZE <- spaces
data_free <- lower case and underscore
Signed-off-by: Frederic Descamps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.