Skip to content

Commit

Permalink
Fixed: Packets not getting registered on the server in singleplayer
Browse files Browse the repository at this point in the history
  • Loading branch information
mysticdrew committed Jun 20, 2024
1 parent 84ce79b commit 93c227b
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 14 deletions.
3 changes: 1 addition & 2 deletions doc/changelog.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@ <h1>Common Networking ${version} for Minecraft ${mcversion}</h1>

<p>New in ${version}</p>
<ul>
<li>Fixed: Exceptions</li>
<li>Updated Fabric to work on both sides.</li>
<li>Fixed: Packets not getting registered on the server in singleplayer.</li>
</ul>
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,18 @@ protected <T> void registerPacket(PacketContainer<T> container)
if (Side.CLIENT.equals(this.side))
{
Constants.LOG.debug("Registering packet {} : {} on the: {}", container.packetIdentifier(), container.messageType(), Side.CLIENT);

ClientPlayNetworking.registerGlobalReceiver(container.packetIdentifier(), ((client, listener, buf, responseSender) -> {
buf.readByte(); // handle forge discriminator
T message = container.decoder().apply(buf);
client.execute(() -> container.handler().accept(new PacketContext<>(message, Side.CLIENT)));
}));
}
else
{
Constants.LOG.debug("Registering packet {} : {} on the: {}", container.packetIdentifier(), container.messageType(), Side.SERVER);

ServerPlayNetworking.registerGlobalReceiver(container.packetIdentifier(), ((server, player, listener, buf, responseSender) -> {
buf.readByte(); // handle forge discriminator
T message = container.decoder().apply(buf);
server.execute(() -> container.handler().accept(new PacketContext<>(player, message, Side.SERVER)));
}));
}
Constants.LOG.debug("Registering packet {} : {} on the: {}", container.packetIdentifier(), container.messageType(), Side.SERVER);
ServerPlayNetworking.registerGlobalReceiver(container.packetIdentifier(), ((server, player, listener, buf, responseSender) -> {
buf.readByte(); // handle forge discriminator
T message = container.decoder().apply(buf);
server.execute(() -> container.handler().accept(new PacketContext<>(player, message, Side.SERVER)));
}));
}
}

Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Project
version=1.0.5
version=1.0.6
group_id=mysticdrew

curseforge_project_id=806044
Expand Down

0 comments on commit 93c227b

Please sign in to comment.