feat(parser): enhance user agent parsing logic and add tests for inva… #76
Conversation
BenjaminAbt
commented
Aug 25, 2025
BenjaminAbt
commented
- fixes TryExtractVersion throws Exception on invalid user agents #75
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the user agent parsing logic to better handle invalid and malformed user agents by improving detection of browser name misspellings and implementing stricter validation patterns. It also removes the overly broad "Mozilla" detection rule that was causing false positives.
- Improved browser detection logic to require proper format (Token/) and prevent misspelling matches
- Added comprehensive test coverage for invalid and malformed user agents
- Removed generic Mozilla detection rule that was too permissive
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| HttpUserAgentParserTests.cs | Adds comprehensive test cases for invalid user agents including misspellings and malformed strings |
| HttpUserAgentStatics.cs | Adds EdgiOS detection rule and removes overly broad Mozilla rule |
| HttpUserAgentParser.cs | Enhances browser detection logic with stricter validation and improved version extraction |
| README.md | Updates benchmark performance metrics reflecting the changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| { | ||
| char c = haystack[i]; | ||
| if (char.IsBetween(c, '0', '9')) | ||
| if (c >= '0' && c <= '9') |
There was a problem hiding this comment.
This is two comparisons now, instead of just one. Either use the uint cast directly, or use char.IsBetween which does the same thing but more readable IMO.
Only the JIT for .NET 10+ is able to optimize that to one comparison (by using the uint cast).
| { | ||
| return false; | ||
| char c = haystack[end]; | ||
| if (!((c >= '0' && c <= '9') || c == '.')) |
